Geocoding V6 Support#1577
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #1577 +/- ##
============================================
+ Coverage 77.44% 77.77% +0.32%
- Complexity 976 1041 +65
============================================
Files 136 156 +20
Lines 4123 4368 +245
Branches 588 606 +18
============================================
+ Hits 3193 3397 +204
- Misses 679 708 +29
- Partials 251 263 +12
|
ahmedaly16
force-pushed
the
df-geocoding-v6-preview
branch
from
eb5adec to
7dce6ad
Compare
ahmedaly16
requested review from
DzmitryFomchyn,
dzinad,
mpothier and
vadzim-vys
and removed request for
a team
trescube
approved these changes
Apr 22, 2024
trescube
left a comment
trescube
left a comment
There was a problem hiding this comment.
Looks great! Very clean, well-structured, and maintainable.
ahmedaly16
force-pushed
the
df-geocoding-v6-preview
branch
from
7af8023 to
57f31a0
Compare
ahmedaly16
force-pushed
the
df-geocoding-v6-preview
branch
from
57f31a0 to
31cbd9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Geocoding V6 is going to be GA on Monday, and it's going to be the default Geocoding API service listed under https://docs.mapbox.com/api/search/geocoding/ instead of V5.
This PR is reopening the original PR by @DzmitryFomchyn: #1550
Also I included all changes that we're aware of that happened to Geocoding V6 since the original PR was closed, I updated the tests as well.