Skip to content

Add step maneuver modifier constants #1142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kmadsen merged 1 commit into from
May 11, 2020
Merged

Add step maneuver modifier constants #1142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions services-directions-models/src/main/java/com/mapbox/api/directions/v5/models/BannerText.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ public static Builder builder() {
* @since 3.0.0
*/
@Nullable
@ManeuverModifier.Type
public abstract String modifier();


Expand Down
1 change: 1 addition & 0 deletions services-directions-models/src/main/java/com/mapbox/api/directions/v5/models/BannerView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ public static Builder builder() {
* @since 5.0.0
*/
@Nullable
@ManeuverModifier.Type
public abstract String modifier();

/**
Expand Down
89 changes: 89 additions & 0 deletions ...directions-models/src/main/java/com/mapbox/api/directions/v5/models/ManeuverModifier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,89 @@
package com.mapbox.api.directions.v5.models;

import androidx.annotation.StringDef;

import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy;

/**
* Constants for the {@link StepManeuver#modifier()}.
*
* @since 5.2.0
*/
public final class ManeuverModifier {

/**
* Indicates "uturn" maneuver modifier.
*
* @since 5.2.0
*/
public static final String UTURN = "uturn";

/**
* Indicates "sharp right" maneuver modifier.
*
* @since 5.2.0
*/
public static final String SHARP_RIGHT = "sharp right";

/**
* Indicates "right" maneuver modifier.
*
* @since 5.2.0
*/
public static final String RIGHT = "right";

/**
* Indicates "slight right" maneuver modifier.
*
* @since 5.2.0
*/
public static final String SLIGHT_RIGHT = "slight right";

/**
* Indicates "straight" maneuver modifier.
*
* @since 5.2.0
*/
public static final String STRAIGHT = "straight";

/**
* Indicates "slight left" maneuver modifier.
*
* @since 5.2.0
*/
public static final String SLIGHT_LEFT = "slight left";

/**
* Indicates "left" maneuver modifier.
*
* @since 5.2.0
*/
public static final String LEFT = "left";

/**
* Indicates "sharp left" maneuver modifier.
*
* @since 5.2.0
*/
public static final String SHARP_LEFT = "sharp left";

/**
* Representation of ManeuverModifier in form of logical types.
*
* @since 5.2.0
*/
@Retention(RetentionPolicy.SOURCE)
@StringDef({
ManeuverModifier.UTURN,
ManeuverModifier.SHARP_RIGHT,
ManeuverModifier.RIGHT,
ManeuverModifier.SLIGHT_RIGHT,
ManeuverModifier.STRAIGHT,
ManeuverModifier.SLIGHT_LEFT,
ManeuverModifier.LEFT,
ManeuverModifier.SHARP_LEFT
})
@interface Type {

@Guardiola31337 Guardiola31337 May 13, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arghh this needs to be public Java... 🤦

@kmadsen kmadsen May 13, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh java

}
}
2 changes: 1 addition & 1 deletion ...ces-directions-models/src/main/java/com/mapbox/api/directions/v5/models/StepManeuver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ public abstract Builder bearingAfter(
* @return this builder for chaining options together
* @since 3.0.0
*/
public abstract Builder modifier(@Nullable String modifier);
public abstract Builder modifier(@Nullable @ManeuverModifier.Type String modifier);

/**
* An optional integer indicating number of the exit to take. If exit is undefined the
Expand Down
2 changes: 1 addition & 1 deletion ...directions-models/src/test/java/com/mapbox/api/directions/v5/models/StepManeuverTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public void testToFromJson2() {
StepManeuver stepManeuver = StepManeuver.builder()
.rawLocation(new double[]{13.424671, 52.508812})
.type("turn")
.modifier("left")
.modifier(ManeuverModifier.LEFT)
.bearingBefore(299.0)
.bearingAfter(202.0)
.instruction("Turn left onto Adalbertstraße")
Expand Down