looks good! 🚀

Thanks! One question, do I need to include the change log with the PR or should it be done later in the release phase? I didn't find a needs changelog label in this repository.

Thanks! One question, do I need to include the change log with the PR or should it be done later in the release phase? I didn't find a needs changelog label in this repository.

good question! if possible add it directly to the changelog. This repository doesn't see as much traffic as our gl-native monorepo. (in gl-natiuve we avoid adding changelog due to conflicts on master, for this project this isn't an issue).

@langsmith do you have any thoughts about this PR? and which section should I add the change log to?

@langsmith fixed the mentioned suggestions, any further thoughts? And where should the change log go?

You've already got the intersectionSearchSanity test, but there's usually a test that just checks that the right parameters are in the request URL. I didn't want to commit it to this branch, but the following test checks for and . It's passing fine on my local machine.

  @Test
  public void intersectionSearchAndAddedCorrectly() throws IOException {
    MapboxGeocoding mapboxGeocoding = MapboxGeocoding.builder()
      .accessToken(ACCESS_TOKEN)
      .intersectionStreets("Market Street", "Fremont Street")
      .proximity("-122.39738575285674,37.792514711136945")
      .geocodingTypes(GeocodingCriteria.TYPE_ADDRESS)
      .baseUrl(mockUrl.toString())
      .build();
    assertNotNull(mapboxGeocoding);
    assertTrue(mapboxGeocoding.cloneCall().request().url().toString().contains("and"));
  }

Regarding changelog. Sure, go ahead and add a master section, similar to https://github.com/mapbox/mapbox-gl-native/blob/master/platform/android/CHANGELOG.md#master. Then add this pr to that section.