Skip to content

Conversation

@rahul-s-bhatt
Copy link
Contributor

Added Contact form UI.

Added Contact form UI.
@rahul-s-bhatt rahul-s-bhatt mentioned this pull request Oct 4, 2021
@piechowiakmichal
Copy link
Member

I thought you would also add a backend but that's no problem. It looks great, but I see you also changed the color of the search bar and its display in the mobile version. Could you fix it? Could you also adapt the website to mobile display?

@piechowiakmichal
Copy link
Member

I see that the navbar broke down in the mobile version on every page.

@piechowiakmichal piechowiakmichal linked an issue Oct 4, 2021 that may be closed by this pull request
@rahul-s-bhatt
Copy link
Contributor Author

I'll make the changes and commit the latest version with the provided feedback!

@rahul-s-bhatt
Copy link
Contributor Author

rahul-s-bhatt commented Oct 5, 2021

@piechowiakmichal Could you elaborate on the mobile UI part?
Are you suggesting it to club it into a hamburger menu on left and search bar on right ( as it is currently) ?

@piechowiakmichal
Copy link
Member

The easiest way is to explain by video.

The shape and color of the search bar have changed. As you can see in the video, the website does not display properly on mobile devices

2021-10-05.18-08-32_Trim.mp4

@piechowiakmichal
Copy link
Member

piechowiakmichal commented Oct 5, 2021

I would like to go back to the earlier look of the search bar and that the website is displayed correctly on mobile devices.

@rahul-s-bhatt
Copy link
Contributor Author

I would like to go back to the earlier look of the search bar and that the website is displayed correctly on mobile devices.

image
is this fine?

@piechowiakmichal
Copy link
Member

Fine, but what's this green button for?

@rahul-s-bhatt
Copy link
Contributor Author

Fine, but what's this green button for?

What green button?

@piechowiakmichal
Copy link
Member

@rahulbhatt1899 bottom right corner

@rahul-s-bhatt
Copy link
Contributor Author

rahul-s-bhatt commented Oct 8, 2021

Fine, but what's this green button for?

that is a chrome extension I have called Grammarly, this isn't on the actual website. That extension helps you write better, you can google it if you want. It's actually useful.

@piechowiakmichal
Copy link
Member

Fine, so upload update here if you finish work.

@rahul-s-bhatt
Copy link
Contributor Author

Fine, so upload update here if you finish work.

Yeah, I have already done what you suggested.

@piechowiakmichal
Copy link
Member

So, upload changes here.

Changed Search bar color back to normal
@rahul-s-bhatt
Copy link
Contributor Author

Hey, I commited the new version now, could you check if it's alright!

@piechowiakmichal
Copy link
Member

piechowiakmichal commented Oct 11, 2021

Thanks!

@piechowiakmichal piechowiakmichal merged commit 25d0778 into many-passwords:main Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding a contact form

2 participants