feat: revamp bank soal per jurusan, add angkatan filter checkboxes - #87

src/routes/_authenticated/admin.peserta.index.tsx-241-241 (1)

241-241: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Update the empty-state column span.

The table now has seven columns, but the empty-state cell at Line 292 still uses colSpan={6}. Set it to 7 so the empty state spans the full table.

Proposed fix

-<TableCell colSpan={6} className="h-48 text-center">
+<TableCell colSpan={7} className="h-48 text-center">

Also applies to: 259-259

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/routes/_authenticated/admin.peserta.index.tsx` at line 241, Update the
empty-state table cell’s colSpan from 6 to 7 in the table containing the “Tahun
Angkatan” TableHead, including the corresponding occurrence noted near the other
header, so the empty state spans all seven columns.

src/lib/server/redis/service.ts-146-159 (1)

146-159: 🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win

Clamp the computed TTL before calling SET ... EX.

durationMinutes reaches this method from the request body of setSessionTimerServer without validation. Redis rejects an expire value that is zero or negative with an error. A durationMinutes of -60 or lower produces durationMinutes * 60 + 3600 <= 0, and the SET throws. The catch block is empty, so the call then writes the same non-positive TTL into setFallback on Line 158, where Date.now() + ttl * 1000 yields an already-expired entry. The timer is lost with no log line.

Clamp the TTL and reject a non-finite durationMinutes.

🐛 Proposed fix

   async setSessionTimer(sesiId: string, endsAt: number, durationMinutes: number): Promise<void> {
     const key = REDIS_KEYS.sessionTimer(sesiId);
+    const safeMinutes = Number.isFinite(durationMinutes)
+      ? Math.min(Math.max(durationMinutes, 1), 24 * 60)
+      : 60;
+    const ttlSeconds = safeMinutes * 60 + 3600;
     const data = JSON.stringify({ endsAt, durationMinutes, startedAt: Date.now() });
 
     if (this.isConnected && this.redis) {
       try {
-        await this.redis.set(key, data, "EX", durationMinutes * 60 + 3600);
+        await this.redis.set(key, data, "EX", ttlSeconds);
         return;
-      } catch {
-        // fallback
+      } catch (err) {
+        console.warn("[Redis] Failed to set session timer, using fallback:", err);
       }
     }
-    this.setFallback(key, data, durationMinutes * 60 + 3600);
+    this.setFallback(key, data, ttlSeconds);
   }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/lib/server/redis/service.ts` around lines 146 - 159, Update
setSessionTimer to reject non-finite durationMinutes and clamp the computed TTL
to a positive minimum before using it with redis.set or setFallback. Reuse the
same validated TTL for both storage paths so invalid durations cannot produce
Redis errors or already-expired fallback entries.

src/routes/_authenticated/admin.index.tsx-80-85 (1)

80-85: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Use consistent Indonesian scale abbreviations.

The formatter mixes locales. rb is the Indonesian abbreviation for ribu (thousand), but M is the English abbreviation for million. In Indonesian shorthand, M reads as miliar (billion), and million is jt. The decimal separator is also a period instead of the Indonesian comma.

🌐 Proposed fix for locale-consistent formatting

   const formatNumber = (num: number) => {
-    if (num >= 1000000) return `${(num / 1000000).toFixed(1)}M`;
-    if (num >= 1000) return `${(num / 1000).toFixed(1)}rb`;
-    return num.toString();
+    if (num >= 1_000_000) return `${(num / 1_000_000).toLocaleString("id-ID", { maximumFractionDigits: 1 })} jt`;
+    if (num >= 1_000) return `${(num / 1_000).toLocaleString("id-ID", { maximumFractionDigits: 1 })} rb`;
+    return num.toLocaleString("id-ID");
   };

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/routes/_authenticated/admin.index.tsx` around lines 80 - 85, Update
formatNumber to use Indonesian abbreviations consistently: represent millions
with “jt” and thousands with “rb”, and replace the decimal point with an
Indonesian comma in formatted values. Preserve the existing one-decimal rounding
and plain numeric output for values below one thousand.

src/routes/_authenticated/admin.tsx-189-195 (1)

189-195: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

The rule-key fallback highlights the wrong item when two items share one rule key.

/admin/peserta and /admin/peserta/online both resolve to the peserta rule key. For a pathname such as /admin/peserta/kartu, the exact /admin/peserta item returns false at line 190, then the fallback at lines 192-194 marks "Pantau Ujian Live" as active. The dashboard "Kartu Peserta" shortcut links to that path, so the state is reachable.

Restrict the fallback to items whose own path is a prefix of the pathname, or to the single longest-matching item in the group.

🐛 Proposed fix for the active-item fallback

 function isNavItemActive(item: NavItem, pathname: string) {
   if (item.exact) return pathname === item.to;
   if (pathname === item.to || pathname.startsWith(`${item.to}/`)) return true;
+  // Only fall back to rule-key matching when the item is not a deeper sibling
+  // under a shared rule (e.g. /admin/peserta vs /admin/peserta/online).
+  if (!pathname.startsWith(`${item.to.split("/").slice(0, 3).join("/")}/`)) return false;
   const rule = resolveAdminRouteRule(pathname);
   const itemRule = resolveAdminRouteRule(item.to);
   return !!(rule && itemRule && itemRule.key === rule.key);
 }

Prefer selecting the longest matching item.to across the group if that fits the navigation model better.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/routes/_authenticated/admin.tsx` around lines 189 - 195, Update
isNavItemActive so the rule-key fallback cannot activate an item whose item.to
is not a path prefix of pathname; require the item path to match as an exact
path or directory prefix before applying the shared rule-key comparison.
Preserve exact-item handling and prevent shorter same-rule entries such as
/admin/peserta from competing with more specific paths.

src/routes/_authenticated/admin.analitik.index.tsx-142-144 (1)

142-144: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Remove the duplicate exam name.

Line 139 already renders u.nama. Lines 142-144 render the same value again. Remove this block or replace it with distinct metadata.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/routes/_authenticated/admin.analitik.index.tsx` around lines 142 - 144,
Remove the duplicate u.nama rendering from the nearby h3 block in the relevant
component, since the exam name is already rendered earlier. Leave the existing
first rendering intact and only retain this block if it is replaced with
distinct metadata.

src/lib/server/backup/functions.ts-77-77 (1)

77-77: 🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win

Remove the invalid type assertion for angkatanIds.

stringifyJson() returns string, while the Ujian Prisma field expects String; the existing backup import other string-array fields the same way.

Proposed fix

-						angkatanIds: stringifyJson(item.angkatanIds) as unknown as string[],
+						angkatanIds: stringifyJson(item.angkatanIds),

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/lib/server/backup/functions.ts` at line 77, Update the angkatanIds
assignment in the backup Ujian import to remove the unknown/string[] type
assertion and preserve the string returned by stringifyJson(item.angkatanIds),
matching the handling of the other string-array fields.

src/routes/_authenticated/admin.topik.$id.soal.tsx-30-30 (1)

30-30: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Do not block question management when the unit cannot be resolved.

Line 43 treats a missing unit as a missing topic and reports "Topik tidak ditemukan". A topic whose unitId did not migrate then becomes unmanageable, and the message names the wrong cause. Line 339 already tolerates a missing unit in the move dialog. Gate only on topik, and render the breadcrumb conditionally.

🐛 Proposed fix

-  if (!topik || !unit) return (
+  if (!topik) return (

Then guard the breadcrumb:

-              <Link to="/admin/modul/$id/topik" params={{ id: unit.id }} className="hover:text-indigo-600 dark:hover:text-indigo-400 transition-colors">
-                {unit.nama}
-              </Link>
+              {unit && (
+                <Link to="/admin/modul/$id/topik" params={{ id: unit.id }} className="hover:text-indigo-600 dark:hover:text-indigo-400 transition-colors">
+                  {unit.nama}
+                </Link>
+              )}

Also applies to: 43-48

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/routes/_authenticated/admin.topik`.$id.soal.tsx at line 30, Update the
question-management route around the `unit` lookup and the topic-not-found guard
so access is gated only by `topik`; a missing `unit` must not trigger the “Topik
tidak ditemukan” response. Render the breadcrumb conditionally when `unit` is
available, while preserving the existing missing-topic handling and downstream
behavior.

src/components/cbt/CheatSheets.tsx (1)

207-218: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Remove or implement the non-functional controls.

Inv, Keypad, and History on Lines 209-217 are div elements with cursor-pointer and no handler. The Ans button on Line 259 has an empty onClick. Each element looks interactive and does nothing. During an exam this costs the participant time.

The div elements are also not reachable by keyboard and have no role, so keyboard users get no feedback at all.

Remove these controls, or implement them and convert the div elements to button elements. handleDelete on Line 150 is also defined but never bound to a control.

Also applies to: 259-259

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/components/cbt/CheatSheets.tsx` around lines 207 - 218, Remove the
non-functional Inv, Keypad, History, and Ans controls, or implement their
interactions fully. If retained, convert the interactive divs to accessible
button elements with keyboard support and meaningful handlers, and bind the
existing handleDelete function to the appropriate control instead of leaving it
unused or exposing empty onClick behavior.

src/routes/_authenticated/admin.index.tsx (1)

330-350: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Derive the telemetry values instead of hardcoding them.

SQLite Local, Prisma Client, and v1.2.0 are static strings in the view. The version label will drift from package.json after the next release, and the database label will be wrong if the deployment changes provider. Source these values from build-time constants or a server function.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/routes/_authenticated/admin.index.tsx` around lines 330 - 350, Update the
System Environment Telemetry block in the admin page to use existing build-time
constants or a server-provided configuration source for the database provider,
ORM engine, and application version instead of hardcoded “SQLite Local”, “Prisma
Client”, and “v1.2.0” values. Preserve the current labels and styling while
ensuring the displayed values reflect the deployed configuration and package
version.

src/routes/_authenticated/admin.tsx (1)

339-342: 🗄️ Data Integrity & Integration | 🔵 Trivial | ⚡ Quick win

Use the generated route-path union for admin navigation links.

NavItem["to"], pendingTasks[].route, and ShortcutCard.href currently model valid admin paths as plain string, so renamed or deleted links can pass type checks and still navigate to a nonexistent route. Use FileRouteTypes["fullPaths"] or a derived admin route union for these fields so link failures are caught at build time.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/routes/_authenticated/admin.tsx` around lines 339 - 342, The admin
navigation types currently allow arbitrary strings, so invalid or removed routes
bypass type checking. In src/routes/_authenticated/admin.tsx at lines 339-342
and src/routes/_authenticated/admin.index.tsx at lines 283 and 416-419, update
NavItem["to"], pendingTasks[].route, and ShortcutCard.href to use
FileRouteTypes["fullPaths"] or a derived admin route union, and remove the cast
that bypasses Link route validation.

src/lib/server/modul/functions.ts (1)

60-72: 🗄️ Data Integrity & Integration | 🔵 Trivial | ⚡ Quick win

Validate the topik payload with TopikSchema instead of casting to any.

payload is z.any(), and the casts remove the last type check. TopikSchema now requires unitId, so a request that still sends modulId writes a topic with no unit and produces orphan rows in the new model. Parse the payload before the transaction.

♻️ Proposed validation

+			const topikList =
+				action === "bulkSet"
+					? TopikSchema.array().parse(payload)
+					: null;
+			const topikItem =
+				action === "upsert" ? TopikSchema.parse(payload) : null;
+
 			await prisma.$transaction(async (tx) => {
 				if (action === "remove")
 					await tx.topik.delete({ where: { id: String(payload.id) } });
 				else if (action === "bulkSet") {
 					await tx.topik.deleteMany();
-					await tx.topik.createMany({ data: payload as any });
-				} else
-					await tx.topik.upsert({
-						where: { id: payload.id },
-						update: payload as any,
-						create: payload as any,
-					});
+					await tx.topik.createMany({ data: topikList! });
+				} else
+					await tx.topik.upsert({
+						where: { id: topikItem!.id },
+						update: topikItem!,
+						create: topikItem!,
+					});
 			});

Import TopikSchema from @/lib/cbt/types in addition to the existing type imports.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/lib/server/modul/functions.ts` around lines 60 - 72, Validate the topik
payload with TopikSchema before entering the prisma.$transaction callback,
replacing the any-based casts used by the remove, bulkSet, and upsert branches.
Import TopikSchema from `@/lib/cbt/types` and use the parsed payload so unitId is
required and legacy modulId-only requests cannot create orphan topics.

src/routes/_authenticated/admin.modul.tsx (1)

35-46: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Remove the unreachable branch in the shown filter.

canEdit is isUnrestricted(user), and allowedTopikIdSet returns null only when isUnrestricted(user) is true. Line 40 therefore already handles every case where allowedSet is null, and the return true at line 45 is unreachable. The topikRepo.all() call also runs once per unit; hoist it out of the filter.

♻️ Proposed simplification

+  const allTopiks = topikRepo.all();
   const shown = units.filter(u => {
     const isQueryMatch = !query || u.nama.toLowerCase().includes(query.toLowerCase());
     if (!isQueryMatch) return false;
-    
-    // Check if operator has access to any topik in this unit (or if unrestricted)
-    if (canEdit) return true;
-    const unitTopiks = topikRepo.all().filter((t) => t.unitId === u.id);
-    if (allowedSet) {
-      return unitTopiks.some(t => allowedSet.has(t.id));
-    }
-    return true;
+    // Unrestricted operators see every unit.
+    if (!allowedSet) return true;
+    return allTopiks.some((t) => t.unitId === u.id && allowedSet.has(t.id));
   });

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/routes/_authenticated/admin.modul.tsx` around lines 35 - 46, Update the
shown filter to remove the unreachable fallback return after the allowedSet
check, relying on canEdit for unrestricted users and allowedSet membership
otherwise. Hoist the topikRepo.all() result outside the units.filter callback,
then reuse it when determining each unit’s accessible topics.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

src/routes/_authenticated/peserta.ujian.$id.index.tsx (1)

177-180: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick win

Bring token claims under the same user-facing error guard.

claimExamToken() returns { ok: false } in the normal token-error paths, but this handler only catches exceptions from session creation. If claimExamToken() throws, mulai() rejects with an unhandled participant-facing error. Wrap the earlier claim path in the same generic fallback or guarantee all server failures return { ok: false, error }.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/routes/_authenticated/peserta.ujian`.$id.index.tsx around lines 177 -
180, Update mulai() so the claimExamToken() call is covered by the same generic
participant-facing error guard as session creation. Handle thrown claim errors
by showing the existing “Gagal memulai ujian” fallback and returning, while
preserving the current { ok: false } handling for normal token failures.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

scratch/seed-clinical.ts (1)

119-122: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Type soals instead of suppressing no-explicit-any.

model Soal stores TipeSoal and Kesulitan, while soals is inferred with literal strings. Declare soals with the Prisma-generated SoalCreateInput type for the seed insert, then remove both as any casts and their suppression comments.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@scratch/seed-clinical.ts` around lines 119 - 122, Type the soals seed data
using Prisma’s generated SoalCreateInput before the seed insert, then remove the
no-explicit-any suppression comments and both as any casts from tipe and
kesulitan while preserving their existing values.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes