Skip to content

Commit c84d49c

Browse files
KSemenenkoclaude
KSemenenko
and
claude
committed
Drop folder-path prefixes from 132 Core class names
Phase 6 of the review remediation. KeyLoad.Core files were named after their full folder path, so one class was called MessagingCommandsQueueLifecycleQueueLifecycleAccounting. The 132 classes whose names start with their slice and role folders lose that prefix (QueueLifecycleAccounting, ResourceEffectCapture, ...); files move with their classes and every reference in source, tests and docs is rewritten. Fifteen names whose short form would collide with another type or a namespace segment keep their current name. Namespaces still carry the historical Features segment; aligning them with folders touches 1 629 global:: references and is left for a dedicated change. QueueViewLeaseIsolationReads reads the compiled SQL payload as the typed plan (AstQueryRequest) that the gateway has shipped since the single compile path landed. Verification: dotnet build KeyLoad.slnx -warnaserror (0 warnings, 0 errors), dotnet format --verify-no-changes, node scripts/Features/RepositoryGovernance/verify.mjs, and the smoke set QueueViewLeaseIsolationTests, ConnectionGraphPolicyTests, ScriptDomSelectWholeFlowTests, ReadCutCancellationTests and OrleansWalSuccessorTests (7 tests) on the rebuilt binaries. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
1 parent e5aa8bb commit c84d49c

209 files changed

Lines changed: 1079 additions & 1078 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎src/KeyLoad.Clustering/RequestExecution/Admission/CommandWorkAdmission.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ internal static class CommandWorkAdmission
1515
}
1616
var kind = request.Envelope.CommandKind
1717
?? throw Errors.Fail(ErrorCode.TokenInvalidated, GrainRoutingProtocol.InvalidRequest);
18-
if (kind == OperationKind.DropTable || ResourceExecutionQueriesCommandResultBinding.IsResourceFreeCommandWork(kind))
18+
if (kind == OperationKind.DropTable || CommandResultBinding.IsResourceFreeCommandWork(kind))
1919
{
2020
work.Bind([]); // Dropping a resource cannot retain its closing lifetime.
2121
return null;

‎src/KeyLoad.Clustering/Search/Execution/AnnMaintenance/AnnMaintenanceInitialEnrollment.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ internal static class AnnMaintenanceInitialEnrollment
2323
? original : null;
2424
var configureId = AnnMaintenanceChildIdentity.Create(request.CommandId,
2525
AnnMaintenancePhase.Configure, InitialSequence);
26-
global::KeyLoad.Core.SearchCommandsProjectionMaintenanceConfiguration.RequireInitialMaintenanceReservation(configured,
26+
global::KeyLoad.Core.ProjectionMaintenanceConfiguration.RequireInitialMaintenanceReservation(configured,
2727
new ConfigureProjectionConsumerRequest(configureId, request.Consumer, configured.Definition)
2828
{
2929
InitialAnnMaintenance = initial

src/KeyLoad.Core/AnalyticsStore/Commands/AnalyticsStoreCommandsAnalyticsMutations.cs renamed to src/KeyLoad.Core/AnalyticsStore/Commands/AnalyticsMutations.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
using KeyLoad.Storage;
33

44
namespace KeyLoad.Core;
5-
/// <summary>Executes AnalyticsStoreCommandsAnalyticsMutations operations against the caller's database context.</summary>
6-
public static class AnalyticsStoreCommandsAnalyticsMutations
5+
/// <summary>Executes AnalyticsMutations operations against the caller's database context.</summary>
6+
public static class AnalyticsMutations
77
{
88
internal const long AnalyticsAbsentRevision = 0;
99
internal const long AnalyticsRevisionStep = 1;

src/KeyLoad.Core/AnalyticsStore/Queries/AnalyticsStoreQueriesAnalyticsReads.cs renamed to src/KeyLoad.Core/AnalyticsStore/Queries/AnalyticsReads.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
using KeyLoad.Core.Features.ResourceExecution;
44

55
namespace KeyLoad.Core;
6-
/// <summary>Executes AnalyticsStoreQueriesAnalyticsReads operations against the caller's database context.</summary>
7-
public static class AnalyticsStoreQueriesAnalyticsReads
6+
/// <summary>Executes AnalyticsReads operations against the caller's database context.</summary>
7+
public static class AnalyticsReads
88
{
99
internal const int MinimumAnalyticsReadLimit = 0;
1010
internal const int EqualAnalyticsIdentifierOrder = 0;

‎src/KeyLoad.Core/AnalyticsStore/Queries/AnalyticsStoreReadScope.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ internal static AnalyticsStoreReadScope Open(DatabaseEngine database, IKeyValueV
1414
JsonData.Identifier(store);
1515
var principal = database.Principal(view, principalId, database.EvaluationClock.GetUtcNow());
1616
database.Authorization.Require(principal, partition, store, Capability.AnalyticsRead);
17-
var resource = ResourceExecutionQueriesResourceLifetimeReadBinding.BindAuthorizedReadResource(view, partition, store, ResourceKind.AnalyticsStore);
17+
var resource = ResourceLifetimeReadBinding.BindAuthorizedReadResource(view, partition, store, ResourceKind.AnalyticsStore);
1818
AnalyticsStoreValidation.ValidateSchema(resource);
1919
var lifetime = ResourceLifetimeCatalog.Read(view, partition.TenantId, partition.DatabaseId, store, resource)
2020
?? throw Errors.Fail(ErrorCode.Corruption, AnalyticsStoreValidation.Invalid);

‎src/KeyLoad.Core/AnalyticsStore/Validation/AnalyticsStoreLinks.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ private static EntityRef Resolve(DatabaseEngine database, IKeyValueView view, Pr
6262
{
6363
database.Authorization.Require(principal, partition, link.Collection, Capability.DocumentsRead);
6464
var definition = stored
65-
? ResourceExecutionQueriesResourceLifetimeReadBinding.BindAuthorizedReadResource(view, partition, link.Collection, ResourceKind.Collection)
65+
? ResourceLifetimeReadBinding.BindAuthorizedReadResource(view, partition, link.Collection, ResourceKind.Collection)
6666
: database.Resource(view, partition, link.Collection, ResourceKind.Collection);
6767
var lifetime = ResourceLifetimeCatalog.Read(view, partition.TenantId, partition.DatabaseId,
6868
link.Collection, definition) ?? throw Errors.Fail(ErrorCode.NotFound, Unavailable);

‎src/KeyLoad.Core/AtomicCommandCommit.cs‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ internal static StorageOperationResult ApplyCore(this DatabaseEngine engine, Com
5858
admitted = engine.PrepareQueueRetryInView(transaction, admitted);
5959
}
6060

61-
var sequence = siloLocal ? StorageExecutionExecutionStorageOperationApply.InitialCanonicalSequence : canonicalSequence ?? StorageExecutionExecutionStorageOperationApply.SelectNextCanonicalSequence(transaction);
61+
var sequence = siloLocal ? StorageOperationApply.InitialCanonicalSequence : canonicalSequence ?? StorageOperationApply.SelectNextCanonicalSequence(transaction);
6262
var result = engine.ApplyCommittedCommand(transaction, admitted, position, sequence, siloLocal, cancellationToken);
6363
cancellationToken.ThrowIfCancellationRequested();
6464
return result;
@@ -79,7 +79,7 @@ internal static StorageOperationResult ApplyCommittedCommand(this DatabaseEngine
7979

8080
if (!siloLocal)
8181
{
82-
StorageExecutionExecutionStorageOperationApply.RequireNextCanonicalSequence(rosterTransaction, replicationIndex);
82+
StorageOperationApply.RequireNextCanonicalSequence(rosterTransaction, replicationIndex);
8383
}
8484

8585
outcome = outcome with
@@ -98,7 +98,7 @@ internal static StoredOutcome ExecuteAndBuildOutcome(this DatabaseEngine engine,
9898
persistOutcome = false;
9999
var authorizationPending = false;
100100
long policyEpoch = AtomicCommandCommitInitialSequence;
101-
var onlineTextAuthority = SearchCommandsOnlineTextPublicationCommands.CaptureOnlineTextOutcomeAuthority(operation);
101+
var onlineTextAuthority = OnlineTextPublicationCommands.CaptureOnlineTextOutcomeAuthority(operation);
102102
global::KeyLoad.Core.Features.Messaging.RemoteTransferAcceptFailureAuthority? transferFailure = null;
103103
Result<object> result;
104104
global::KeyLoad.Core.Features.DatabaseComposition.CompositionOutcomeAuthority? compositionAuthority = null;
@@ -119,7 +119,7 @@ internal static StoredOutcome ExecuteAndBuildOutcome(this DatabaseEngine engine,
119119

120120
if (!siloLocal)
121121
{
122-
StorageExecutionExecutionStorageOperationApply.RequireNextCanonicalSequence(transaction, replicationIndex);
122+
StorageOperationApply.RequireNextCanonicalSequence(transaction, replicationIndex);
123123
}
124124

125125
engine.RequireOriginalEffectAdmission(transaction, principal, operation);
@@ -147,7 +147,7 @@ internal static StoredOutcome ExecuteAndBuildOutcome(this DatabaseEngine engine,
147147
result = ManagedCode.Communication.Result<object>.Fail(Errors.Problem(ErrorCode.Validation, InvalidCommandJsonMessage));
148148
}
149149

150-
return engine.BuildStoredOutcome(operation, fingerprint, policyEpoch, result, compositionAuthority, partitionScope, onlineTextAuthority, transferFailure, selection.Outcome?.CanonicalSequence ?? (persistOutcome ? replicationIndex : StorageExecutionExecutionStorageOperationApply.ReadCanonicalSequence(transaction)));
150+
return engine.BuildStoredOutcome(operation, fingerprint, policyEpoch, result, compositionAuthority, partitionScope, onlineTextAuthority, transferFailure, selection.Outcome?.CanonicalSequence ?? (persistOutcome ? replicationIndex : StorageOperationApply.ReadCanonicalSequence(transaction)));
151151
}
152152

153153
internal static void ValidateCommandClock(AtomicPartitionRosterTransaction view, DateTimeOffset evaluatedAt)

‎src/KeyLoad.Core/AtomicMutationApplication.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ internal static ImmutableArray<MutationReceipt> ApplyMutations(this DatabaseEngi
6969
tx.PutRecord(KeySpace.Partition(DocumentEpochSpace, partition, collection), checked(engine.DocumentEpoch(tx, partition, collection) + AtomicMutationApplicationAdjacentElementOffset));
7070
}
7171

72-
ResourceExecutionAdmissionResourceEffectCompositionScopes.RequireCompleteCompositionEffects(tx, operation, preparingComposition);
72+
ResourceEffectCompositionScopes.RequireCompleteCompositionEffects(tx, operation, preparingComposition);
7373
return receipts.Count == receipts.Capacity ? receipts.MoveToImmutable() : receipts.ToImmutable();
7474
}
7575

@@ -106,7 +106,7 @@ internal static void AcceptExpandedMutation(this DatabaseEngine engine, ref int
106106
{
107107
if (++count > engine.Limits.MaxBatchMutations)
108108
{
109-
throw Errors.Fail(ErrorCode.ResourceExhausted, AuthorizationCommandsCommandAuthorization.MutationCountBudgetMessage);
109+
throw Errors.Fail(ErrorCode.ResourceExhausted, CommandAuthorization.MutationCountBudgetMessage);
110110
}
111111
}
112112

‎src/KeyLoad.Core/Authorization/Commands/AuthorizationCommands.cs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,15 @@ internal static void AuthorizeBatchMutations(this DatabaseEngine engine, IKeyVal
99
const int EmptyMutationsLength = 0;
1010
if (!allowEmpty && request.Mutations.Length == EmptyMutationsLength || request.Mutations.Length > engine.Limits.MaxBatchMutations)
1111
{
12-
throw Errors.Fail(ErrorCode.ResourceExhausted, AuthorizationCommandsCommandAuthorization.MutationCountBudgetMessage);
12+
throw Errors.Fail(ErrorCode.ResourceExhausted, CommandAuthorization.MutationCountBudgetMessage);
1313
}
1414

1515
foreach (var mutation in request.Mutations)
1616
{
1717
ProtocolValidation.ValidateMutationStructure(mutation);
1818
if (allowEmpty && mutation is QueueToGraph or GraphToQueueMutation or AdvanceQueueDeadline)
1919
{
20-
throw Errors.Fail(ErrorCode.UnsupportedCapability, AuthorizationCommandsCommandAuthorization.CompositionBatchRequiredMessage);
20+
throw Errors.Fail(ErrorCode.UnsupportedCapability, CommandAuthorization.CompositionBatchRequiredMessage);
2121
}
2222

2323
JsonData.Identifier(mutation.Resource);
@@ -61,7 +61,7 @@ internal static Capability BatchMutationCapability(Mutation mutation)
6161
StoreAggregateSnapshot => Capability.EventsSnapshotsManage | Capability.EventsRead,
6262
PutVector => Capability.DocumentsWrite,
6363
global::KeyLoad.ApplyVectorProjection => Capability.DocumentsWrite,
64-
_ => throw Errors.Fail(ErrorCode.UnsupportedCapability, AuthorizationCommandsCommandAuthorization.UnsupportedBatchMutationMessage)
64+
_ => throw Errors.Fail(ErrorCode.UnsupportedCapability, CommandAuthorization.UnsupportedBatchMutationMessage)
6565
};
6666
}
6767
}

src/KeyLoad.Core/Authorization/Commands/AuthorizationCommandsCommandAuthorization.cs renamed to src/KeyLoad.Core/Authorization/Commands/CommandAuthorization.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
using ManagedCode.Communication.Commands;
44

55
namespace KeyLoad.Core;
6-
/// <summary>Executes AuthorizationCommandsCommandAuthorization operations against the caller's database context.</summary>
7-
public static class AuthorizationCommandsCommandAuthorization
6+
/// <summary>Executes CommandAuthorization operations against the caller's database context.</summary>
7+
public static class CommandAuthorization
88
{
99
internal const string ClusterAdministrationRequiredMessage = "Cluster administration is required.";
1010
internal const string MutationCountBudgetMessage = "The mutation count exceeds its budget.";

0 commit comments

Comments
 (0)