#123 delete all button on report listing screen #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceallen
commented
May 8, 2024
| try: | ||
| get_serializer().delete_all_for_report_name(report_name) | ||
| get_all_result_keys(get_serializer(), limit=DEFAULT_RESULT_LIMIT, force_reload=True) | ||
| return jsonify({"status": "ok"}), 200 |
There was a problem hiding this comment.
This needs some enhancement - exposing the JSON to the end user is a bit too low-level
There was a problem hiding this comment.
I've set this up to redirect to the front page.
jonbannister
requested changes
May 15, 2024
There was a problem hiding this comment.
Looks promising! A couple things:
- I think the serialiser implementation of
delete_all_for_report_name()wasn't committed? We should at least have an abstract method. - Needs some tests - consider adding to some of our new frontend testing as well :)
- Add to CHANGELOG.md please
| e.preventDefault(); | ||
| var confirmed = confirm('Are you sure you wish to delete all reports?'); | ||
| if (confirmed) { | ||
| window.location.href = this.getAttribute('data-href'); |
There was a problem hiding this comment.
This could take a long time - do we want to display a spinner or even a status update to the user?
| :return: A JSON which contains "status" which will either be "ok" or "error". | ||
| """ | ||
| try: | ||
| get_serializer().delete_all_for_report_name(report_name) |
There was a problem hiding this comment.
Where is this implemented?
|
|
||
|
|
||
| @run_report_bp.route("/delete_all_reports/<path:report_name>", methods=["GET", "POST"]) | ||
| def delete_all_reports(report_name): |
| </a> | ||
| <button class="ui button red" id="deleteAllReportsButton" data-href="/delete_all_reports/{{ report_name }}"> | ||
| Delete all reports | ||
| </button> |
There was a problem hiding this comment.
Ideally we could add a Jest test for this as well please
jonbannister
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #123