OAuthWebFilter: Fix 'parameter should not be assigned' warning

dpursehouse · lucamilanesio · commit c5c76db62048 · 2015-10-25T15:46:15.000Z
Don't assign a new value to the parameter that was passed
into the method.  Use the locally created copy.

Change-Id: I3a4c8ff3da6f3d0adf45cf77794459dd67595525
diff --git a/github-oauth/src/main/java/com/googlesource/gerrit/plugins/github/oauth/OAuthWebFilter.java b/github-oauth/src/main/java/com/googlesource/gerrit/plugins/github/oauth/OAuthWebFilter.java
@@ -89,7 +89,8 @@ public void doFilter(ServletRequest request, ServletResponse response,
         login(request, httpRequest, httpResponse, ghLogin);
       } else {
         if (OAuthProtocol.isOAuthLogout(httpRequest)) {
-          response = logout(request, response, chain, httpRequest);
+          httpResponse =
+              (HttpServletResponse) logout(request, httpResponse, chain, httpRequest);
         }
 
         if (ghLogin != null && ghLogin.isLoggedIn()) {
@@ -99,7 +100,7 @@ public void doFilter(ServletRequest request, ServletResponse response,
                   GITHUB_EXT_ID + ghLogin.getToken().accessToken);
         }
 
-        chain.doFilter(httpRequest, response);
+        chain.doFilter(httpRequest, httpResponse);
       }
     } finally {
       HttpSession httpSession = httpRequest.getSession();

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,8 @@ public void doFilter(ServletRequest request, ServletResponse response,`
`89`	`89`	`login(request, httpRequest, httpResponse, ghLogin);`
`90`	`90`	`} else {`
`91`	`91`	`if (OAuthProtocol.isOAuthLogout(httpRequest)) {`
`92`		`- response = logout(request, response, chain, httpRequest);`
	`92`	`+ httpResponse =`
	`93`	`+ (HttpServletResponse) logout(request, httpResponse, chain, httpRequest);`
`93`	`94`	`}`
`94`	`95`
`95`	`96`	`if (ghLogin != null && ghLogin.isLoggedIn()) {`
`@@ -99,7 +100,7 @@ public void doFilter(ServletRequest request, ServletResponse response,`
`99`	`100`	`GITHUB_EXT_ID + ghLogin.getToken().accessToken);`
`100`	`101`	`}`
`101`	`102`
`102`		`- chain.doFilter(httpRequest, response);`
	`103`	`+ chain.doFilter(httpRequest, httpResponse);`
`103`	`104`	`}`
`104`	`105`	`} finally {`
`105`	`106`	`HttpSession httpSession = httpRequest.getSession();`