FindBugs error: include encoding for wrapped login response

lucamilanesio · dpursehouse · commit 298b38c2cda2 · 2014-08-19T08:58:25.000Z
When wrapping the login response (with added HTTP headers)
we need to include the target encoding otherwise we will
default to the JVM encoding instead of the one set into
the HTTP response.

Change-Id: I81c2ec44e1c7ed62e14faeba5dd13a14468b95b1
diff --git a/github-oauth/src/main/java/com/googlesource/gerrit/plugins/github/oauth/AuthenticatedLoginHttpResponse.java b/github-oauth/src/main/java/com/googlesource/gerrit/plugins/github/oauth/AuthenticatedLoginHttpResponse.java
@@ -15,6 +15,7 @@
 
 import java.io.ByteArrayOutputStream;
 import java.io.IOException;
+import java.io.OutputStreamWriter;
 import java.io.PrintWriter;
 import java.util.Collection;
 import java.util.Collections;
@@ -174,7 +175,8 @@ public ServletResponse getResponse() {
 
   @Override
   public PrintWriter getWriter() throws IOException {
-    return new PrintWriter(outputStream);
+    return new PrintWriter(new OutputStreamWriter(outputStream,
+        characterEncoding));
   }
 
   @Override
