Skip to content

Commit a9fa45c

Browse files
bitwisemanbitwiseman
authored
Merge pull request hub4j#1939 from bitwiseman/feature/ci-site
Re-enable site for v2.x
2 parents 87805f6 + 9419cd9 commit a9fa45c

File tree

175 files changed

+1699
-33
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

175 files changed

+1699
-33
lines changed

‎.github/workflows/maven-build.yml‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,9 @@ jobs:
5757
- name: Maven Site
5858
env:
5959
MAVEN_OPTS: ${{ env.JAVA_11_PLUS_MAVEN_OPTS }}
60-
run: mvn -B clean site -D enable-ci --file pom.xml
60+
# running install site seems to more closely imitate real site deployment,
61+
# more likely to prevent failed deployment
62+
run: mvn -B clean install site -DskipTests --file pom.xml
6163
test:
6264
name: test (${{ matrix.os }}, Java ${{ matrix.java }})
6365
# Does not require build output, but orders execution to prevent launching test workflows when simple build fails

‎.github/workflows/publish_release_branch.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323
- name: Maven Install and Site with Code Coverage
2424
env:
2525
MAVEN_OPTS: ${{ env.JAVA_11_PLUS_MAVEN_OPTS }}
26-
run: mvn -B clean install -D enable-ci --file pom.xml "-Dsurefire.argLine=--add-opens java.base/java.net=ALL-UNNAMED"
26+
run: mvn -B clean install site -D enable-ci --file pom.xml "-Dsurefire.argLine=--add-opens java.base/java.net=ALL-UNNAMED"
2727

2828
- uses: actions/upload-artifact@v4
2929
with:

‎pom.xml‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -202,8 +202,9 @@
202202
<plugin>
203203
<groupId>org.apache.maven.plugins</groupId>
204204
<artifactId>maven-javadoc-plugin</artifactId>
205-
<version>3.8.0</version>
205+
<version>3.10.0</version>
206206
<configuration>
207+
<source>11</source>
207208
<release>11</release>
208209
<failOnWarnings>true</failOnWarnings>
209210
<doclint>all</doclint>
@@ -279,6 +280,7 @@
279280
<configuration>
280281
<source>11</source>
281282
<target>11</target>
283+
<release>11</release>
282284
<annotationProcessorPaths>
283285
<annotationProcessorPath>
284286
<groupId>org.jenkins-ci</groupId>

‎src/main/java/org/kohsuke/github/AbstractBuilder.java‎

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import javax.annotation.CheckForNull;
88
import javax.annotation.Nonnull;
99

10-
// TODO: Auto-generated Javadoc
1110
/**
1211
* An abstract data object builder/updater.
1312
*
@@ -42,7 +41,7 @@
4241
* Intermediate return type for this builder returned by calls to {@link #with(String, Object)}. If {@link S}
4342
* the same as {@link R}, this builder will commit changes after each call to {@link #with(String, Object)}.
4443
*/
45-
abstract class AbstractBuilder<R, S> extends GitHubInteractiveObject {
44+
abstract class AbstractBuilder<R, S> extends GitHubInteractiveObject implements GitHubRequestBuilderDone<R> {
4645

4746
@Nonnull
4847
private final Class<R> returnType;
@@ -58,9 +57,9 @@ abstract class AbstractBuilder<R, S> extends GitHubInteractiveObject {
5857

5958
// TODO: Not sure how update-in-place behavior should be controlled
6059
// However, it certainly can be controlled dynamically down to the instance level or inherited for all children of
61-
// some
60+
// some connection.
61+
6262
/** The update in place. */
63-
// connection.
6463
protected boolean updateInPlace;
6564

6665
/**
@@ -96,14 +95,9 @@ protected AbstractBuilder(@Nonnull Class<R> finalReturnType,
9695
}
9796

9897
/**
99-
* Finishes an update, committing changes.
100-
*
101-
* This method may update-in-place or not. Either way it returns the resulting instance.
102-
*
103-
* @return an instance with updated current data
104-
* @throws IOException
105-
* if there is an I/O Exception
98+
* {@inheritDoc}
10699
*/
100+
@Override
107101
@Nonnull
108102
@BetaApi
109103
public R done() throws IOException {

‎src/main/java/org/kohsuke/github/GHApp.java‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,12 @@
2020
*/
2121
public class GHApp extends GHObject {
2222

23+
/**
24+
* Create default GHApp instance
25+
*/
26+
public GHApp() {
27+
}
28+
2329
private GHUser owner;
2430
private String name;
2531
private String slug;

‎src/main/java/org/kohsuke/github/GHAppFromManifest.java‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,12 @@
88
*/
99
public class GHAppFromManifest extends GHApp {
1010

11+
/**
12+
* Create default GHAppFromManifest instance
13+
*/
14+
public GHAppFromManifest() {
15+
}
16+
1117
private String clientId;
1218
private String clientSecret;
1319
private String webhookSecret;

‎src/main/java/org/kohsuke/github/GHAppInstallation.java‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,13 @@
2424
* @see GHApp#getInstallationByUser(String) GHApp#getInstallationByUser(String)
2525
*/
2626
public class GHAppInstallation extends GHObject {
27+
28+
/**
29+
* Create default GHAppInstallation instance
30+
*/
31+
public GHAppInstallation() {
32+
}
33+
2734
private GHUser account;
2835

2936
@JsonProperty("access_tokens_url")

‎src/main/java/org/kohsuke/github/GHAppInstallationToken.java‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,13 @@
1111
* @see GHAppInstallation#createToken() GHAppInstallation#createToken()
1212
*/
1313
public class GHAppInstallationToken extends GitHubInteractiveObject {
14+
15+
/**
16+
* Create default GHAppInstallationToken instance
17+
*/
18+
public GHAppInstallationToken() {
19+
}
20+
1421
private String token;
1522

1623
/** The expires at. */

‎src/main/java/org/kohsuke/github/GHArtifact.java‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,12 @@
2020
*/
2121
public class GHArtifact extends GHObject {
2222

23+
/**
24+
* Create default GHArtifact instance
25+
*/
26+
public GHArtifact() {
27+
}
28+
2329
// Not provided by the API.
2430
@JsonIgnore
2531
private GHRepository owner;

‎src/main/java/org/kohsuke/github/GHAsset.java‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,12 @@
1212
*/
1313
public class GHAsset extends GHObject {
1414

15+
/**
16+
* Create default GHAsset instance
17+
*/
18+
public GHAsset() {
19+
}
20+
1521
/** The owner. */
1622
GHRepository owner;
1723
private String name;

0 commit comments

Comments
 (0)