forked from swiftwasm/JavaScriptKit
-
-
Notifications
You must be signed in to change notification settings - Fork 0
[pull] main from swiftwasm:main #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pull
wants to merge
841
commits into
majacQ:main
Choose a base branch
from
swiftwasm:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add BridgeJS playground
This suppresses warnings from swift-syntax
BridgeJS: Move intrinsic declarations to JavaScriptKit under SPI
To mark it `throws`
BridgeJS: Add `throws(JSException)` to imported methods
Use of class type for `SwiftRuntime` in `instantiate.d.ts` makes it difficult to union types of two `instantiate` variants.
PackageToJS: Use non-class type for SwiftRuntime in instantiate.d.ts
emsdk includes `node` directory but the `which` function returned it as a valid executable.
Fix `which` not to return directories
…stry In FinalizationRegistry mode, the `swjs_free_host_function` should be called with the Swift heap object ID, not the JS closure object ID. The wrong argument was causing: - Swift closures to be leaked, because FinalizationRegistry attempted to release a JS object ID that was never registered as a Swift closure. - Unintended deallocation of unrelated closures when a reused JS object ID happened to match a valid Swift closure ID by coincidence. This eventually led to crashes with `The JSClosure has been already released by Swift side.`
When generating `@_extern(wasm)` function declarations in the BridgeJS plugin, we now need to ensure that they are placed at the top level of the module, rather than nested within other declarations because of the restrictions of the main branch Swift compiler.
Bumps [actions/checkout](https://github.com/actions/checkout) from 5 to 6. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v5...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
BridgeJS: Adjust for the latest top-level requirement for `@_extern(wasm)`
BridgeJS: Extend snapshot test setup for exports <-> global this by including mixed module test case
…mespace BridgeJS: exposeToGlobal configuration option to control declare global declaration
… reversed order and intermediate properties
…rameters BridgeJS: Fix ordering issue with multiple stack based parameters
* PackageToJS: Make some options optional in option setup functions * Examples: Add NodeJS example * Documentation: Add Package output structure article * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Revert browser.d.ts API change --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
BridgeJS: Enable struct as default parameter and enable default parameters in struct init / methods
BridgeJS: Struct and struct vs classes benchmarks
[NFC] BridgeJS: Codegen code organisation and minor cleanups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )