Skip to content

Updates JavaScript for linting#25

Merged
dkotter merged 2 commits intodevelopfrom
fix/js-linting
Jun 7, 2024
Merged

Updates JavaScript for linting#25
dkotter merged 2 commits intodevelopfrom
fix/js-linting

Conversation

@noraconley
Copy link
Copy Markdown
Collaborator

@noraconley noraconley commented Jun 6, 2024

Description of the Change

  • Updates jQuery Datepicker to use core version (this was previously completely broken.
    • Removes translated versions
  • Fixes linting errors in JavaScript files

Closes #12

How to test the Change

  • Ensure Datepicker works on frontend for Birthday field
  • Ensure translated Datepicker works as expected
  • Hide CSS table in admin works

Changelog Entry

Fixed - Datepicker display on frontend

Credits

@nateconley

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@noraconley noraconley requested a review from dkotter June 6, 2024 21:44
@noraconley noraconley self-assigned this Jun 6, 2024
@noraconley
Copy link
Copy Markdown
Collaborator Author

noraconley commented Jun 6, 2024

@dkotter I have this PR targeted at the base linting branch. One open question for you: scrollTo is currently broken, seemingly due to it relying on an older version of jQuery that expectes $.browser. Should we update scrollTo as part of this implementation?

Base automatically changed from fix/linting to develop June 7, 2024 13:32
@github-actions github-actions bot added this to the 1.6.0 milestone Jun 7, 2024
@github-actions github-actions bot added the needs:code-review This requires code review. label Jun 7, 2024
@dkotter
Copy link
Copy Markdown
Collaborator

dkotter commented Jun 7, 2024

One open question for you: scrollTo is currently broken, seemingly due to it relying on an older version of jQuery that expects $.browser. Should we update scrollTo as part of this implementation?

I'm not sure how that library is used here but I'd say let's address that as part of either #1 or #2. Depending on how that is used, we can replace with something else or maybe get rid of it all together

@dkotter dkotter merged commit ddcdcf7 into develop Jun 7, 2024
@dkotter dkotter deleted the fix/js-linting branch June 7, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkotter dkotter dkotter approved these changes

Assignees

@noraconley noraconley

Labels

needs:code-review This requires code review.

Projects

None yet

Milestone

1.6.0

Development

Successfully merging this pull request may close these issues.

Add and resolve errors from linting actions

2 participants

@noraconley @dkotter