Merged
Conversation
github-actions
bot
added
the
needs:feedback
|
@nateconley thanks for the PR! Could you please fill out the PR template with description, changelog, and credits information so that we can properly review and merge this? |
dkotter
approved these changes
Jun 4, 2024
Collaborator
dkotter
left a comment
dkotter
left a comment
There was a problem hiding this comment.
Looks good, going to merge this in so other PRs can take advantage of this cleanup. Noting at some point it would probably be good to add PHP headers to those view files, especially the ones that don't have any PHP, I think we can include a PHP header that explains what the file does which will also resolve a PHPCS lint issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Adds basic formatting. This PR is intended to have only changes which should not possibly have an impact on functionality.
A first iteration on #12
Examples:
echo sprintfand useprintfHow to test the Change
Changelog Entry
Checklist: