Update all actions we use in our workflows to pull from specific pinned commits#128
Merged
Update all actions we use in our workflows to pull from specific pinned commits#128
Conversation
iamdharmesh
approved these changes
Mar 19, 2025
Collaborator
iamdharmesh
left a comment
iamdharmesh
left a comment
There was a problem hiding this comment.
PR changes look good and all actions are passing, except for the following:
- Dependency Review: I'm not entirely sure about this, but it appears to be due to the "MIT License identified as invalid" issue.
- E2E Cypress Tests / WP trunk: These tests are failing because of an
insertBlockcommand issue with WP 6.8 in the Cypress utils library version 0.4.
Collaborator
Author
Yes, that does seem like the issue. We've encountered this across multiple plugins now. I've downgraded to an older version and that seems to work for now.
Update to the latest 0.5.0 release and tests are passing now |
jeffpaul
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
In order to help protect against compromised actions, instead of including actions based on their major version (like v4), this PR switches all the actions we use to pull based on the commit hash from the latest release.
While this does impact maintenance a bit going forward, it ensures that we we're always using actions that we (hopefully) trust and if an action gets compromised (which happens) we don't have to worry that we're using a compromised action. This also goes along with what GitHub suggests.
How to test the Change
Ensure all our workflows still run as expected
Changelog Entry
Credits
Props @dkotter, @jeffpaul
Checklist: