Fix unit tests for Composer Installer #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karyna-t
force-pushed
the
php8-compatibility/change-composer-dependencies
branch
from
2c23ded to
89dc756
Compare
xmav
reviewed
Nov 29, 2021
tests/MagentoHackathon/Composer/Magento/PathMappingTranslationTest.php
Outdated
Show resolved
Hide resolved
xmav
reviewed
Nov 30, 2021
xmav
reviewed
Dec 2, 2021
| "description":"Composer installer for Magento modules", | ||
| "keywords":[ "composer-installer", "magento"], | ||
| "minimum-stability":"stable", | ||
| "test_version": "dev-master", |
There was a problem hiding this comment.
I don't think this needed. (added by tests ?)
Author
There was a problem hiding this comment.
I added this. It's needed for tests
magento-composer-installer/tests/MagentoHackathon/Composer/Magento/FullStack/AbstractTest.php:21
magento-composer-installer/tests/MagentoHackathon/Composer/Magento/FullStack/AbstractTest.php:59
perl -pi -e \'s/"version"/"test_version"/g\' ./composer.json
|
@magento import code to magento-trigger/magento-composer-installer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes failed unit tests for Composer Installer.
Should be merged after #32