Skip to content

Enhance/v2 refactor input validation - mega refactor#132

Merged
JasonShin merged 34 commits intov2from
enhance/v2-refactor-input-validation
Nov 12, 2018
Merged

Enhance/v2 refactor input validation - mega refactor#132
JasonShin merged 34 commits intov2from
enhance/v2-refactor-input-validation

Conversation

@JasonShin
Copy link
Member

@JasonShin JasonShin commented Nov 7, 2018

Mega refactoring

Done

  1. No more object-based model APIs: changed fit({ X, y }) to fit(X ,y)
  2. Validation is done based on the new utilities that use Tensorflow.js
  3. Better typing system for the method inputs. For example TypeMatrix2D<number> and TypeMatrix1D<number>
  4. Implement IMlModel to all the models

@JasonShin JasonShin added the enhancement New feature or request label Nov 7, 2018
@JasonShin JasonShin changed the title Enhance/v2 refactor input validation Enhance/v2 refactor input validation - mega refactor Nov 9, 2018
@JasonShin JasonShin merged commit bc187dc into v2 Nov 12, 2018
@JasonShin JasonShin deleted the enhance/v2-refactor-input-validation branch November 12, 2018 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant