Skip to content

Commit f677c5a

Browse files
author
Marc Cohen
committed
Update CONTRIB.md
1 parent 471848b commit f677c5a

1 file changed

Lines changed: 12 additions & 3 deletions

File tree

CONTRIB.md

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,20 @@ Please fill out either the individual or corporate Contributor License Agreement
1111

1212
Follow either of the two links above to access the appropriate CLA and instructions for how to sign and return it. Once we receive it, we'll be able to accept your pull requests.
1313

14-
## Submitting Patches
14+
## Submitting a Bug Fix
1515

1616
1. Sign a Contributor License Agreement (see details above).
17-
1. Coordinate your plans with team members that are listed on the repo in question. This ensures that work isn't being duplicated and communicating your plan early also generally leads to better patches.
18-
1. Fork the desired repo, make and test your changes
17+
1. Fork the desired repo, make code changes and test your bug fix.
18+
1. Ensure that your code adheres to the existing style in the sample to which you are contributing. Refer to the [Google Cloud Platform Samples Style Guide](https://github.com/GoogleCloudPlatform/Home/wiki/STYLE.html) for the recommended coding standards for this organization. In the event the existing style conflicts with the recommended style, the former takes precedence over the latter.
19+
1. Ensure that your code has an appropriate set of unit tests, which you have executed.
20+
1. Submit a pull request. A pull request should address one issue in the repo. Please don't mix more than one logical change per pull request, because it makes the history hard to follow.
21+
22+
## Submitting an Enhancement
23+
24+
1. Sign a Contributor License Agreement (see details above).
25+
1. Submit an enhancement issue to the repo in question. This ensures that work isn't being duplicated and communicating your plan early also generally leads to better patches.
26+
1. The repo owner will respond to your enhancement issue promptly. Instructional value is the top priority when evaluating enhancements for this collection of repos.
27+
1. If your enhancement issue is accepted, fork the desired repo, make your code changes and test your enhancement.
1928
1. Ensure that your code adheres to the existing style in the sample to which you are contributing. Refer to the [Google Cloud Platform Samples Style Guide](https://github.com/GoogleCloudPlatform/Home/wiki/STYLE.html) for the recommended coding standards for this organization. In the event the existing style conflicts with the recommended style, the former takes precedence over the latter.
2029
1. Ensure that your code has an appropriate set of unit tests, which you have executed.
2130
1. Submit a pull request. A pull request should address one issue in the repo. Please don't mix more than one logical change per pull request, because it makes the history hard to follow.

0 commit comments

Comments
 (0)