Skip to content

Commit 66fd933

Browse files
author
Marc Cohen
committed
Update CONTRIB.md
1 parent 0c6b147 commit 66fd933

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

CONTRIB.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,11 @@ Follow either of the two links above to access the appropriate CLA and instructi
2121

2222
## Submitting an Enhancement
2323

24-
1. Sign a Contributor License Agreement (see details above).
24+
2525
1. Submit an enhancement issue to the repo in question. This ensures that work isn't being duplicated and communicating your plan early also generally leads to better patches.
2626
1. The repo owner will respond to your enhancement issue promptly. Instructional value is the top priority when evaluating enhancements for this collection of repos.
27-
1. If your enhancement issue is accepted, fork the desired repo, make your code changes and test your enhancement.
27+
1. If your enhancement issue is accepted, and you haven't already done so, sign a Contributor License Agreement (see details above).
28+
1. fork the desired repo, make your code changes and test your enhancement.
2829
1. Ensure that your code adheres to the existing style in the sample to which you are contributing. Refer to the [Google Cloud Platform Samples Style Guide](https://github.com/GoogleCloudPlatform/Home/wiki/STYLE.html) for the recommended coding standards for this organization. In the event the existing style conflicts with the recommended style, the former takes precedence over the latter.
2930
1. Ensure that your code has an appropriate set of unit tests, which you have executed.
3031
1. Submit a pull request. A pull request should address one issue in the repo. Please don't mix more than one logical change per pull request, because it makes the history hard to follow.
@@ -34,8 +35,8 @@ Follow either of the two links above to access the appropriate CLA and instructi
3435
1. Sign a Contributor License Agreement (see details above).
3536
1. Submit an enhancement issue to the GoogleCloudPlatform/Template repo.
3637
1. The repo owner will respond to your enhancement issue promptly. Instructional value is the top priority when evaluating new app proposals for this collection of repos.
37-
1. If your proposal is accepted, build your app in your own repo.
38-
1. Follow this naming convention for your new repo:
38+
1. If your proposal is accepted, and you haven't already done so, sign a Contributor License Agreement (see details above).
39+
1. Create your own repo for your app following this naming convention:
3940
* {product}-{app-name}-{language}
4041
* products: appengine, compute, storage, bigquery, prediction, cloudsql
4142
* example: appengine-guestbook-python

0 commit comments

Comments
 (0)