Customer - Campos duplicados / Validações de campos - Fixes #63 #64 #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame, com esse tratamento faz parecer que os campos Social Name e Trade Name estão duplicados
Author
|
Descobri que meu tratamento está incompleto, em breve irei postar o tratamento devido, por favor aguardarem o mesmo antes de fazerem o merge. |
feeh27
changed the title
feeh27
changed the title
Author
|
Fiz as modificações necessárias, fico no aguardo da revisão. Desde já agradeço. |
feeh27
commented
Nov 24, 2020
| } | ||
|
|
||
| //check if field already being used | ||
| $objectManager = \Magento\Framework\App\ObjectManager::getInstance(); |
Author
There was a problem hiding this comment.
Substitui o uso do Object Manager (a Magento não recomenda seu uso, somente em testes), pelo uso do repository.
feeh27
commented
Nov 24, 2020
| value="<?php echo $block->escapeHtml($block->getCustomerValue("socialname")) ?>" | ||
| title="<?php /* @escapeNotVerified */ echo __('Social Name') ?>" | ||
| class="input-text" | ||
| data-validate="{required:<?php echo var_export($block->getStatus("required", "cnpj", "socialname"), true) ?>, 'validate-cpf':true}" > |
Author
There was a problem hiding this comment.
Validação no campo incorreto, por isso fiz a remoção
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No js que faz o tratamento quando é selecionado Pessoa Física / Pessoa Jurídica, tem um tratamento que muda a label do field-name-firstname e do field-name-lastname, porém esses campos independentemente do tipo de pessoa, possuem a mesma label, já que para a Razão Social e Nome Fantasia existe outro campo.