unsafeClassDivZero: change severity to style

danmar · danmar · commit 4cb3548e2bad · 2017-10-21T21:51:58.000+02:00
diff --git a/lib/checkclass.cpp b/lib/checkclass.cpp
@@ -2443,7 +2443,10 @@ void CheckClass::copyCtorAndEqOperatorError(const Token *tok, const std::string
 
 void CheckClass::checkUnsafeClassDivZero(bool test)
 {
-    if (!_settings->isEnabled(Settings::WARNING))
+    // style severity: it is a style decision if classes should be safe or
+    // if users should be required to be careful. I expect that many users
+    // will disagree about these reports.
+    if (!_settings->isEnabled(Settings::STYLE))
         return;
 
     const std::size_t classes = symbolDatabase->classAndStructScopes.size();
@@ -2481,5 +2484,5 @@ void CheckClass::checkUnsafeClassDivZero(bool test)
 void CheckClass::unsafeClassDivZeroError(const Token *tok, const std::string &className, const std::string &methodName, const std::string &varName)
 {
     const std::string s = className + "::" + methodName + "()";
-    reportError(tok, Severity::warning, "unsafeClassDivZero", "Public interface of " + className + " is not safe. When calling " + s + ", if parameter " + varName + " is 0 that leads to division by zero.");
+    reportError(tok, Severity::style, "unsafeClassDivZero", "Public interface of " + className + " is not safe. When calling " + s + ", if parameter " + varName + " is 0 that leads to division by zero.");
 }
diff --git a/test/testclass.cpp b/test/testclass.cpp
@@ -6499,7 +6499,7 @@ class TestClass : public TestFixture {
         // Clear the error log
         errout.str("");
         Settings settings;
-        settings.addEnabled("warning");
+        settings.addEnabled("style");
 
         // Tokenize..
         Tokenizer tokenizer(&settings, this);
@@ -6517,7 +6517,7 @@ class TestClass : public TestFixture {
                                 "  void dostuff(int x);\n"
                                 "}\n"
                                 "void A::dostuff(int x) { int a = 1000 / x; }");
-        ASSERT_EQUALS("[test.cpp:5]: (warning) Public interface of A is not safe. When calling A::dostuff(), if parameter x is 0 that leads to division by zero.\n", errout.str());
+        ASSERT_EQUALS("[test.cpp:5]: (style) Public interface of A is not safe. When calling A::dostuff(), if parameter x is 0 that leads to division by zero.\n", errout.str());
 
         checkUnsafeClassDivZero("class A {\n"
                                 "public:\n"
@@ -6526,7 +6526,7 @@ class TestClass : public TestFixture {
                                 "}\n"
                                 "void A::f1() {}\n"
                                 "void A::f2(int x) { int a = 1000 / x; }");
-        ASSERT_EQUALS("[test.cpp:7]: (warning) Public interface of A is not safe. When calling A::f2(), if parameter x is 0 that leads to division by zero.\n", errout.str());
+        ASSERT_EQUALS("[test.cpp:7]: (style) Public interface of A is not safe. When calling A::f2(), if parameter x is 0 that leads to division by zero.\n", errout.str());
 
         checkUnsafeClassDivZero("class A {\n"
                                 "public:\n"

Original file line number	Diff line number	Diff line change
`@@ -2443,7 +2443,10 @@ void CheckClass::copyCtorAndEqOperatorError(const Token *tok, const std::string`
`2443`	`2443`
`2444`	`2444`	`void CheckClass::checkUnsafeClassDivZero(bool test)`
`2445`	`2445`	`{`
`2446`		`- if (!_settings->isEnabled(Settings::WARNING))`
	`2446`	`+ // style severity: it is a style decision if classes should be safe or`
	`2447`	`+ // if users should be required to be careful. I expect that many users`
	`2448`	`+ // will disagree about these reports.`
	`2449`	`+ if (!_settings->isEnabled(Settings::STYLE))`
`2447`	`2450`	`return;`
`2448`	`2451`
`2449`	`2452`	`const std::size_t classes = symbolDatabase->classAndStructScopes.size();`
`@@ -2481,5 +2484,5 @@ void CheckClass::checkUnsafeClassDivZero(bool test)`
`2481`	`2484`	`void CheckClass::unsafeClassDivZeroError(const Token *tok, const std::string &className, const std::string &methodName, const std::string &varName)`
`2482`	`2485`	`{`
`2483`	`2486`	`const std::string s = className + "::" + methodName + "()";`
`2484`		`- reportError(tok, Severity::warning, "unsafeClassDivZero", "Public interface of " + className + " is not safe. When calling " + s + ", if parameter " + varName + " is 0 that leads to division by zero.");`
	`2487`	`+ reportError(tok, Severity::style, "unsafeClassDivZero", "Public interface of " + className + " is not safe. When calling " + s + ", if parameter " + varName + " is 0 that leads to division by zero.");`
`2485`	`2488`	`}`