-
Notifications
You must be signed in to change notification settings - Fork 3
Feature/ss879 #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Feature/ss879 #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotfix/ss 499
Release/0.1.1.1
…ossible to the uses inside the implementation section This to avoid issues when generating C++Builder compatible code, as the extra includes generate compiling problems with big projects
This is used instead of the conversion from objecto->json when using the method ToJsonString. There is an important issue with this class: the uuid field on the cancellation response is not being correctly parsed, because the field is a dynamic value (the UUID) so the RTTI can't map it to the object. Adding the original JSON string allows the user of this class to parse the JSON directly and extract those values if needed.
Storing the CFDI XML into a file on the current directory is not adequate in a lot of cases: if the user doesn't have privileges to modify that folder, or there are several concurrent users that might need to use this service, and so on. It's not needed to do that file, in the first place: you can pass the XML directly using a TStringStream.
…braries for TLS 1.2 compatibility
FerCarrilloM
approved these changes
Nov 21, 2025
NayeliRamirezL
approved these changes
Nov 21, 2025
martinfnsw
approved these changes
Nov 21, 2025
SebastianSW
approved these changes
Nov 21, 2025
marifersw
added a commit
that referenced
this pull request
Nov 25, 2025
* Removed unnecessary units from the uses clauses, and moved what was possible to the uses inside the implementation section This to avoid issues when generating C++Builder compatible code, as the extra includes generate compiling problems with big projects * Cleanup of unused variable * Added an internal field to store the original JSON string This is used instead of the conversion from objecto->json when using the method ToJsonString. There is an important issue with this class: the uuid field on the cancellation response is not being correctly parsed, because the field is a dynamic value (the UUID) so the RTTI can't map it to the object. Adding the original JSON string allows the user of this class to parse the JSON directly and extract those values if needed. * Removed the storing of the CFDI into a "temporary" file Storing the CFDI XML into a file on the current directory is not adequate in a lot of cases: if the user doesn't have privileges to modify that folder, or there are several concurrent users that might need to use this service, and so on. It's not needed to do that file, in the first place: you can pass the XML directly using a TStringStream. * Improved response handling to retrieve UUID statuses * Improve form to receive response attributes from cancellation methods * Improve form to receive response attributes from cancellation methods * Added attribute invocation specifications and precision to support libraries for TLS 1.2 compatibility * add LICENSE file for Luna Soft project (GPL v3) * add dll files to configuration * remove comments * update version --------- Co-authored-by: martinfnsw <88680430+martinfnsw@users.noreply.github.com> Co-authored-by: Rodrigo Gómez <rgomez@trafficsystem.com.mx>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.