Feature/status-cfdi #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Se agrego el servicio de consulta de estatus CFDI y su UT
SebastianSW
requested review from
FerCarrilloM,
ReyesSW,
SwAeyrton,
marifersw and
martinfnsw
FerCarrilloM
approved these changes
Jun 2, 2023
ReyesSW
approved these changes
Jun 6, 2023
martinfnsw
requested changes
Jun 6, 2023
Contributor
martinfnsw
left a comment
martinfnsw
left a comment
There was a problem hiding this comment.
-Falta agregar java docs
-Se recomienda seguir la estructura de las carpetas, clases response en carpeta response y clases request en carpeta request.
¿algún motivo para nombrar clases como StatusCancelation?
Se agrego Java docs a los clases, se sigue la estructura de carpetas y se cambio el nombre a archivos mal nombrados.
SwAeyrton
requested changes
Jun 7, 2023
src/main/java/mx/com/sw/services/StatusCfdi/StatusCfdiService.java
Outdated
Show resolved
Hide resolved
src/main/java/mx/com/sw/services/StatusCfdi/StatusCfdiService.java
Outdated
Show resolved
Hide resolved
src/main/java/mx/com/sw/services/StatusCfdi/StatusCfdiService.java
Outdated
Show resolved
Hide resolved
src/test/java/mx/com/sw/services/StatusCfdi/StatusCfdiServiceTest.java
Outdated
Show resolved
Hide resolved
src/test/java/mx/com/sw/services/StatusCfdi/StatusCfdiServiceTest.java
Outdated
Show resolved
Hide resolved
Se corrigió la visualización de datos de terceros, se separo clases y métodos públicos y se elimina el pase de parámetros por el usuario.
Se actualiza readme luego de las mejoras
SwAeyrton
requested changes
Jun 8, 2023
src/main/java/mx/com/sw/services/StatusCfdi/StatusCfdiService.java
Outdated
Show resolved
Hide resolved
SwAeyrton
approved these changes
Jun 13, 2023
marifersw
approved these changes
Jun 13, 2023
martinfnsw
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.