Skip to content

Commit 4f91683

Browse files
FerCarrilloMFerCarrilloM
committed
Fix UT
1 parent 21d5008 commit 4f91683

File tree

6 files changed

+39
-35
lines changed

6 files changed

+39
-35
lines changed

‎src/test/java/mx/com/sw/services/cfdi40/helpers/IssueJsonV4.java‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ public IssueJsonV4(Boolean isToken) throws ServicesException {
3939
@Override
4040
public StampResponseV1 stampResponseV1(String fileName, String stampVersion, boolean signed,
4141
boolean isBase64) throws ServicesException {
42-
return issue.timbrarV1(getSettings().getJsonCFDI(fileName, isBase64), getSettings().getEmail(), null, false);
42+
return issue.timbrarV1(getSettings().getJsonCFDI(fileName, isBase64), getSettings().getCorreo(), null, false);
4343
}
4444

4545
/**
@@ -48,7 +48,7 @@ public StampResponseV1 stampResponseV1(String fileName, String stampVersion, boo
4848
@Override
4949
public StampResponseV2 stampResponseV2(String fileName, String stampVersion, boolean signed,
5050
boolean isBase64) throws ServicesException {
51-
return issue.timbrarV2(getSettings().getJsonCFDI(fileName, isBase64), getSettings().getEmail(), null, false);
51+
return issue.timbrarV2(getSettings().getJsonCFDI(fileName, isBase64), getSettings().getCorreo(), null, false);
5252
}
5353

5454
/**
@@ -57,7 +57,7 @@ public StampResponseV2 stampResponseV2(String fileName, String stampVersion, boo
5757
@Override
5858
public StampResponseV3 stampResponseV3(String fileName, String stampVersion, boolean signed,
5959
boolean isBase64) throws ServicesException {
60-
return issue.timbrarV3(getSettings().getJsonCFDI(fileName, isBase64), getSettings().getEmail(), null, false);
60+
return issue.timbrarV3(getSettings().getJsonCFDI(fileName, isBase64), getSettings().getCorreo(), null, false);
6161
}
6262

6363
/**
@@ -66,6 +66,6 @@ public StampResponseV3 stampResponseV3(String fileName, String stampVersion, boo
6666
@Override
6767
public StampResponseV4 stampResponseV4(String fileName, String stampVersion, boolean signed,
6868
boolean isBase64) throws ServicesException {
69-
return issue.timbrarV4(getSettings().getJsonCFDI(fileName, isBase64), getSettings().getEmail(), null, false);
69+
return issue.timbrarV4(getSettings().getJsonCFDI(fileName, isBase64), getSettings().getCorreo(), null, false);
7070
}
7171
}

‎src/test/java/mx/com/sw/services/cfdi40/helpers/IssueV4.java‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ public IssueV4(Boolean isToken) throws ServicesException {
3939
public StampResponseV1 stampResponseV1(String fileName, String stampVersion, boolean signed,
4040
boolean isBase64) throws ServicesException {
4141
return issue.timbrarV1(getSettings().getCFDI(fileName, false, "4.0", isBase64),
42-
getSettings().getEmail(), null, false, isBase64);
42+
getSettings().getCorreo(), null, false, isBase64);
4343
}
4444

4545
/**
@@ -49,7 +49,7 @@ public StampResponseV1 stampResponseV1(String fileName, String stampVersion, boo
4949
public StampResponseV2 stampResponseV2(String fileName, String stampVersion, boolean signed,
5050
boolean isBase64) throws ServicesException {
5151
return issue.timbrarV2(getSettings().getCFDI(fileName, false, "4.0", isBase64),
52-
getSettings().getEmail(), null, false, isBase64);
52+
getSettings().getCorreo(), null, false, isBase64);
5353
}
5454

5555
/**
@@ -59,7 +59,7 @@ public StampResponseV2 stampResponseV2(String fileName, String stampVersion, boo
5959
public StampResponseV3 stampResponseV3(String fileName, String stampVersion, boolean signed,
6060
boolean isBase64) throws ServicesException {
6161
return issue.timbrarV3(getSettings().getCFDI(fileName, false, "4.0", isBase64),
62-
getSettings().getEmail(), null, false, isBase64);
62+
getSettings().getCorreo(), null, false, isBase64);
6363
}
6464

6565
/**
@@ -69,6 +69,6 @@ public StampResponseV3 stampResponseV3(String fileName, String stampVersion, boo
6969
public StampResponseV4 stampResponseV4(String fileName, String stampVersion, boolean signed,
7070
boolean isBase64) throws ServicesException {
7171
return issue.timbrarV4(getSettings().getCFDI(fileName, false, "4.0", isBase64),
72-
getSettings().getEmail(), null, false, isBase64);
72+
getSettings().getCorreo(), null, false, isBase64);
7373
}
7474
}

‎src/test/java/mx/com/sw/services/cfdi40/helpers/StampV4.java‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public StampV4(Boolean isToken) throws ServicesException {
3737
public StampResponseV1 stampResponseV1(String fileName, String stampVersion, boolean signed,
3838
boolean isBase64) throws ServicesException {
3939
return stamp.timbrarV1(getSettings().getCFDI(fileName, true, "4.0", isBase64),
40-
getSettings().getEmail(), null, false, isBase64);
40+
getSettings().getCorreo(), null, false, isBase64);
4141
}
4242

4343
/**
@@ -47,7 +47,7 @@ public StampResponseV1 stampResponseV1(String fileName, String stampVersion, boo
4747
public StampResponseV2 stampResponseV2(String fileName, String stampVersion, boolean signed,
4848
boolean isBase64) throws ServicesException {
4949
return stamp.timbrarV2(getSettings().getCFDI(fileName, true, "4.0", isBase64),
50-
getSettings().getEmail(), null, false, isBase64);
50+
getSettings().getCorreo(), null, false, isBase64);
5151
}
5252

5353
/**
@@ -57,7 +57,7 @@ public StampResponseV2 stampResponseV2(String fileName, String stampVersion, boo
5757
public StampResponseV3 stampResponseV3(String fileName, String stampVersion, boolean signed,
5858
boolean isBase64) throws ServicesException {
5959
return stamp.timbrarV3(getSettings().getCFDI(fileName, true, "4.0", isBase64),
60-
getSettings().getEmail(), null, false, isBase64);
60+
getSettings().getCorreo(), null, false, isBase64);
6161
}
6262

6363
/**
@@ -67,6 +67,6 @@ public StampResponseV3 stampResponseV3(String fileName, String stampVersion, boo
6767
public StampResponseV4 stampResponseV4(String fileName, String stampVersion, boolean signed,
6868
boolean isBase64) throws ServicesException {
6969
return stamp.timbrarV4(getSettings().getCFDI(fileName, true, "4.0", isBase64),
70-
getSettings().getEmail(), null, false, isBase64);
70+
getSettings().getCorreo(), null, false, isBase64);
7171
}
7272
}

‎src/test/java/mx/com/sw/services/issue/IssueJsonTest.java‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ public void testV4StampV1() {
197197
IssueJsonV4 stamp = new IssueJsonV4(settings.getUrlSW(), settings.getUserSW(), settings.getPasswordSW(),
198198
null, 0);
199199
String json = settings.getJsonCFDI();
200-
StampResponseV1 response = stamp.timbrarV1(json, settings.getEmail(), null, false);
200+
StampResponseV1 response = stamp.timbrarV1(json, settings.getCorreo(), null, false);
201201
Assertions.assertNotNull(response);
202202
Assertions.assertNotNull(response.getData());
203203
Assertions.assertNotNull(response.getStatus());
@@ -217,7 +217,8 @@ public void testV4StampV1_errorEmail() {
217217
IssueJsonV4 stamp = new IssueJsonV4(settings.getUrlSW(), settings.getUserSW(), settings.getPasswordSW(),
218218
null, 0);
219219
String json = settings.getJsonCFDI();
220-
StampResponseV1 response = stamp.timbrarV1(json, "correotest.com.mx", null, false);
220+
List<String> email = Arrays.asList("invalid email");
221+
StampResponseV1 response = stamp.timbrarV1(json, email, null, false);
221222
String messageExpect = "El listado de correos no contiene un formato válido o alguno de los correos es inválido.";
222223
Assertions.assertNotNull(response);
223224
Assertions.assertTrue("error".equalsIgnoreCase(response.getStatus()));
@@ -236,8 +237,7 @@ public void testV4StampV1_maxEmail() {
236237
IssueJsonV4 stamp = new IssueJsonV4(settings.getUrlSW(), settings.getUserSW(), settings.getPasswordSW(),
237238
null, 0);
238239
String json = settings.getJsonCFDI();
239-
String emails = "correo@test.com.mx, correo@test2.com.mx, correo@test3.com.mx, correo@test4.com.mx, correo@test5.com.mx, correo@test6.com.mx";
240-
StampResponseV1 response = stamp.timbrarV1(json, emails, null, false);
240+
StampResponseV1 response = stamp.timbrarV1(json, settings.getCorreos(), null, false);
241241
String messageExpect = "El listado de correos está vacío o contiene más de 5 correos.";
242242
Assertions.assertNotNull(response);
243243
Assertions.assertTrue("error".equalsIgnoreCase(response.getStatus()));
@@ -339,7 +339,7 @@ public void testV4StampV2() {
339339
IssueJsonV4 stamp = new IssueJsonV4(settings.getUrlSW(), settings.getUserSW(), settings.getPasswordSW(),
340340
null, 0);
341341
String json = settings.getJsonCFDI();
342-
StampResponseV2 response = stamp.timbrarV2(json, settings.getEmail(), null, false);
342+
StampResponseV2 response = stamp.timbrarV2(json, settings.getCorreo(), null, false);
343343
Assertions.assertNotNull(response);
344344
Assertions.assertNotNull(response.getData());
345345
Assertions.assertNotNull(response.getStatus());
@@ -358,7 +358,7 @@ public void testV4StampV3() {
358358
try {
359359
IssueJsonV4 stamp = new IssueJsonV4(settings.getUrlSW(), settings.getTokenSW(), null, 0);
360360
String json = settings.getJsonCFDI();
361-
StampResponseV3 response = stamp.timbrarV3(json, settings.getEmail(), null, false);
361+
StampResponseV3 response = stamp.timbrarV3(json, settings.getCorreo(), null, false);
362362
Assertions.assertNotNull(response);
363363
Assertions.assertNotNull(response.getData());
364364
Assertions.assertNotNull(response.getStatus());
@@ -377,7 +377,7 @@ public void testV4StampV4() {
377377
try {
378378
IssueJsonV4 stamp = new IssueJsonV4(settings.getUrlSW(), settings.getTokenSW(), null, 0);
379379
String json = settings.getJsonCFDI();
380-
StampResponseV4 response = stamp.timbrarV4(json, settings.getEmail(), null, false);
380+
StampResponseV4 response = stamp.timbrarV4(json, settings.getCorreo(), null, false);
381381
Assertions.assertNotNull(response);
382382
Assertions.assertNotNull(response.getData());
383383
Assertions.assertNotNull(response.getStatus());

‎src/test/java/mx/com/sw/services/issue/IssueTest.java‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,9 @@
77
import mx.com.sw.services.stamp.responses.StampResponseV3;
88
import mx.com.sw.services.stamp.responses.StampResponseV4;
99

10+
import java.util.Arrays;
1011
import java.util.Collections;
12+
import java.util.List;
1113
import java.util.UUID;
1214
import java.util.stream.Collectors;
1315

@@ -111,7 +113,7 @@ public void testStampV1_email() {
111113
try {
112114
IssueV4 stamp = new IssueV4(settings.getUrlSW(), settings.getUserSW(), settings.getPasswordSW(), null, 0);
113115
String xml = settings.getCFDI(false);
114-
StampResponseV1 response = stamp.timbrarV1(xml, settings.getEmail(), null, false, false);
116+
StampResponseV1 response = stamp.timbrarV1(xml, settings.getCorreo(), null, false, false);
115117
Assertions.assertNotNull(response);
116118
Assertions.assertNotNull(response.getData());
117119
Assertions.assertNotNull(response.getStatus());
@@ -129,7 +131,8 @@ public void testStampV1_errorEmail() {
129131
try {
130132
IssueV4 stamp = new IssueV4(settings.getUrlSW(), settings.getUserSW(), settings.getPasswordSW(), null, 0);
131133
String xml = settings.getCFDI(false);
132-
StampResponseV1 response = stamp.timbrarV1(xml, "correotest.com.mx", null, false, false);
134+
List<String> email = Arrays.asList("invalid email");
135+
StampResponseV1 response = stamp.timbrarV1(xml, email, null, false, false);
133136
String messageExpect = "El listado de correos no contiene un formato válido o alguno de los correos es inválido.";
134137
Assertions.assertNotNull(response);
135138
Assertions.assertTrue("error".equalsIgnoreCase(response.getStatus()));
@@ -147,8 +150,7 @@ public void testStampV1_maxEmail() {
147150
try {
148151
IssueV4 stamp = new IssueV4(settings.getUrlSW(), settings.getUserSW(), settings.getPasswordSW(), null, 0);
149152
String xml = settings.getCFDI(false);
150-
String emails = "correo@test.com.mx, correo@test2.com.mx, correo@test3.com.mx, correo@test4.com.mx, correo@test5.com.mx, correo@test6.com.mx";
151-
StampResponseV1 response = stamp.timbrarV1(xml, emails, null, false, false);
153+
StampResponseV1 response = stamp.timbrarV1(xml, settings.getCorreos(), null, false, false);
152154
String messageExpect = "El listado de correos está vacío o contiene más de 5 correos.";
153155
Assertions.assertNotNull(response);
154156
Assertions.assertTrue("error".equalsIgnoreCase(response.getStatus()));

‎src/test/java/mx/com/sw/services/stamp/StampV4Test.java‎

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,9 @@
77
import mx.com.sw.services.stamp.responses.StampResponseV3;
88
import mx.com.sw.services.stamp.responses.StampResponseV4;
99

10+
import java.util.Arrays;
1011
import java.util.Collections;
12+
import java.util.List;
1113
import java.util.UUID;
1214
import java.util.stream.Collectors;
1315

@@ -39,7 +41,7 @@ public void testStampV1() {
3941
try {
4042
StampV4 stamp = new StampV4(settings.getUrlSW(), settings.getUserSW(), settings.getPasswordSW(), null, 0);
4143
String xml = settings.getCFDI(true);
42-
StampResponseV1 response = stamp.timbrarV1(xml, settings.getEmail(), null,false, false);
44+
StampResponseV1 response = stamp.timbrarV1(xml, settings.getCorreo(), null,false, false);
4345
Assertions.assertNotNull(response);
4446
Assertions.assertNotNull(response.getData());
4547
Assertions.assertNotNull(response.getStatus());
@@ -58,7 +60,8 @@ public void testV4StampV1_errorEmail() {
5860
try {
5961
StampV4 stamp = new StampV4(settings.getUrlSW(), settings.getUserSW(), settings.getPasswordSW(), null, 0);
6062
String xml = settings.getCFDI(true);
61-
StampResponseV1 response = stamp.timbrarV1(xml, "correotest.com.mx", null,false, false);
63+
List<String> email = Arrays.asList("invalid email");
64+
StampResponseV1 response = stamp.timbrarV1(xml, email, null,false, false);
6265
String messageExpect = "El listado de correos no contiene un formato válido o alguno de los correos es inválido.";
6366
Assertions.assertNotNull(response);
6467
Assertions.assertTrue("error".equalsIgnoreCase(response.getStatus()));
@@ -76,8 +79,7 @@ public void testV4StampV1_maxEmail() {
7679
try {
7780
StampV4 stamp = new StampV4(settings.getUrlSW(), settings.getUserSW(), settings.getPasswordSW(), null, 0);
7881
String xml = settings.getCFDI(true);
79-
String emails = "correo@test.com.mx, correo@test2.com.mx, correo@test3.com.mx, correo@test4.com.mx, correo@test5.com.mx, correo@test6.com.mx";
80-
StampResponseV1 response = stamp.timbrarV1(xml, emails, null,false, false);
82+
StampResponseV1 response = stamp.timbrarV1(xml, settings.getCorreos(), null,false, false);
8183
String messageExpect = "El listado de correos está vacío o contiene más de 5 correos.";
8284
Assertions.assertNotNull(response);
8385
Assertions.assertTrue("error".equalsIgnoreCase(response.getStatus()));
@@ -174,7 +176,7 @@ public void testStampV2() {
174176
try {
175177
StampV4 stamp = new StampV4(settings.getUrlSW(), settings.getUserSW(), settings.getPasswordSW(), null, 0);
176178
String xml = settings.getCFDI(true);
177-
StampResponseV2 response = stamp.timbrarV2(xml, settings.getEmail(), null, false, false);
179+
StampResponseV2 response = stamp.timbrarV2(xml, settings.getCorreo(), null, false, false);
178180
Assertions.assertNotNull(response);
179181
Assertions.assertNotNull(response.getData());
180182
Assertions.assertNotNull(response.getStatus());
@@ -234,7 +236,7 @@ public void testStampV3() {
234236
try {
235237
StampV4 stamp = new StampV4(settings.getUrlSW(), settings.getUserSW(), settings.getPasswordSW(), null, 0);
236238
String xml = settings.getCFDI(true);
237-
StampResponseV3 response = stamp.timbrarV3(xml, settings.getEmail(),null, false, false);
239+
StampResponseV3 response = stamp.timbrarV3(xml, settings.getCorreo(),null, false, false);
238240
Assertions.assertNotNull(response);
239241
Assertions.assertNotNull(response.getData());
240242
Assertions.assertNotNull(response.getStatus());
@@ -273,7 +275,7 @@ public void testStampV4() {
273275
try {
274276
StampV4 stamp = new StampV4(settings.getUrlSW(), settings.getUserSW(), settings.getPasswordSW(), null, 0);
275277
String xml = settings.getCFDI(true);
276-
StampResponseV4 response = stamp.timbrarV4(xml, settings.getEmail(),null, false, false);
278+
StampResponseV4 response = stamp.timbrarV4(xml, settings.getCorreo(),null, false, false);
277279
Assertions.assertNotNull(response);
278280
Assertions.assertNotNull(response.getData());
279281
Assertions.assertNotNull(response.getStatus());
@@ -293,7 +295,7 @@ public void testStampV4_customId() {
293295
StampV4 stamp = new StampV4(settings.getUrlSW(), settings.getUserSW(), settings.getPasswordSW(), null, 0);
294296
String xml = settings.getCFDI(true);
295297
String customId = UUID.randomUUID().toString();
296-
StampResponseV4 response = stamp.timbrarV4(xml, settings.getEmail(),customId, false, false);
298+
StampResponseV4 response = stamp.timbrarV4(xml, settings.getCorreo(),customId, false, false);
297299
Assertions.assertNotNull(response);
298300
Assertions.assertNotNull(response.getData());
299301
Assertions.assertNotNull(response.getStatus());
@@ -312,7 +314,7 @@ public void testStampV1B64() {
312314
try {
313315
StampV4 stamp = new StampV4(settings.getUrlSW(), settings.getUserSW(), settings.getPasswordSW(), null, 0);
314316
String xml = settings.getCFDIB64(true);
315-
StampResponseV1 response = stamp.timbrarV1(xml, settings.getEmail(), null,false, true);
317+
StampResponseV1 response = stamp.timbrarV1(xml, settings.getCorreo(), null,false, true);
316318
Assertions.assertNotNull(response);
317319
Assertions.assertNotNull(response.getData());
318320
Assertions.assertNotNull(response.getStatus());
@@ -331,7 +333,7 @@ public void testStampV2B64() {
331333
try {
332334
StampV4 stamp = new StampV4(settings.getUrlSW(), settings.getUserSW(), settings.getPasswordSW(), null, 0);
333335
String xml = settings.getCFDIB64(true);
334-
StampResponseV2 response = stamp.timbrarV2(xml, settings.getEmail(),null, false, true);
336+
StampResponseV2 response = stamp.timbrarV2(xml, settings.getCorreo(),null, false, true);
335337
Assertions.assertNotNull(response);
336338
Assertions.assertNotNull(response.getData());
337339
Assertions.assertNotNull(response.getStatus());
@@ -350,7 +352,7 @@ public void testStampV3B64() {
350352
try {
351353
StampV4 stamp = new StampV4(settings.getUrlSW(), settings.getUserSW(), settings.getPasswordSW(), null, 0);
352354
String xml = settings.getCFDIB64(true);
353-
StampResponseV3 response = stamp.timbrarV3(xml, settings.getEmail(),null, false, true);
355+
StampResponseV3 response = stamp.timbrarV3(xml, settings.getCorreo(),null, false, true);
354356
Assertions.assertNotNull(response);
355357
Assertions.assertNotNull(response.getData());
356358
Assertions.assertNotNull(response.getStatus());
@@ -369,7 +371,7 @@ public void testStampV4B64() {
369371
try {
370372
StampV4 stamp = new StampV4(settings.getUrlSW(), settings.getUserSW(), settings.getPasswordSW(), null, 0);
371373
String xml = settings.getCFDIB64(true);
372-
StampResponseV4 response = stamp.timbrarV4(xml, settings.getEmail(),null, false, true);
374+
StampResponseV4 response = stamp.timbrarV4(xml, settings.getCorreo(),null, false, true);
373375
Assertions.assertNotNull(response);
374376
Assertions.assertNotNull(response.getData());
375377
Assertions.assertNotNull(response.getStatus());

0 commit comments

Comments
 (0)