Skip to content

Commit 3783f90

Browse files
FerCarrilloMFerCarrilloM
committed
-Se elimina texto descriptivo erroneo.
-Se unifica a camelCase. -Se modifican funciones en pruebas unitarias. -Se modifica el README por las funciones alteradas.
1 parent ecd33b6 commit 3783f90

File tree

5 files changed

+66
-63
lines changed

5 files changed

+66
-63
lines changed

‎README.md‎

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1081,13 +1081,13 @@ public class App {
10811081
if(lista != null) {
10821082
for(int i=0; i<lista.size(); i++) {
10831083
CsdData dato = lista.get(i);
1084-
System.out.println(dato.getIssuer_rfc());
1085-
System.out.println(dato.getIssuer_business_name());
1086-
System.out.println(dato.getCertificate_number());
1087-
System.out.println(dato.getCertificate_type());
1088-
System.out.println(dato.getIs_active());
1089-
System.out.println(dato.getValid_from());
1090-
System.out.println(dato.getValid_to());
1084+
System.out.println(dato.getIssuerRfc());
1085+
System.out.println(dato.getIssuerBusinessName());
1086+
System.out.println(dato.getCertificateNumber());
1087+
System.out.println(dato.getCertificateType());
1088+
System.out.println(dato.getIsActive());
1089+
System.out.println(dato.getValidFrom());
1090+
System.out.println(dato.getValidTo());
10911091
}
10921092
}
10931093

@@ -1141,13 +1141,13 @@ public class App {
11411141
CsdUtils csd = new CsdUtils("http://services.test.sw.com.mx", "T2lYQ0t4L0R....ReplaceForRealToken", null, 0);
11421142
CsdDataResponse response = csd.GetCsd(NoCertificado);
11431143
//En caso exitoso se podran obtener los siguientes datos
1144-
System.out.println(response.getData().getIssuer_rfc());
1145-
System.out.println(response.getData().getIssuer_business_name());
1146-
System.out.println(response.getData().getCertificate_number());
1147-
System.out.println(response.getData().getCertificate_type());
1148-
System.out.println(response.getData().getIs_active());
1149-
System.out.println(response.getData().getValid_from());
1150-
System.out.println(response.getData().getValid_to());
1144+
System.out.println(response.getData().getIssuerRfc());
1145+
System.out.println(response.getData().getIssuerBusinessName());
1146+
System.out.println(response.getData().getCertificateNumber());
1147+
System.out.println(response.getData().getCertificateType());
1148+
System.out.println(response.getData().getIsActive());
1149+
System.out.println(response.getData().getValidFrom());
1150+
System.out.println(response.getData().getValidTo());
11511151

11521152
//En caso de error, se pueden visualizar los campos message y/o messageDetail
11531153
System.out.println("Error");

‎src/main/java/mx/com/sw/services/csd/CsdService.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ public abstract class CsdService extends Services{
1212

1313
/**
1414
* Constructor de la clase.
15-
* @param url url base de la API
15+
* @param url url Services
1616
* @param user correo o usuario de SW
1717
* @param password password de SW.
1818
* @param proxy ip o dominio de proxy (null si no se utiliza)
@@ -26,7 +26,7 @@ protected CsdService(String url, String user, String password, String proxy,
2626

2727
/**
2828
* Constructor de la clase.
29-
* @param url url base de la API
29+
* @param url url Services
3030
* @param token token infinito de SW.
3131
* @param proxy ip o dominio de proxy (null si no se utiliza)
3232
* @param proxyPort número de puerto de proxy (cualquier valor si proxy es null)

‎src/main/java/mx/com/sw/services/csd/CsdUtils.java‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,7 @@ public class CsdUtils extends CsdService{
1616
/**
1717
* Constructor de la clase.
1818
*
19-
* @param url url base de la API
20-
* @param urlapi url base de la API servicios
19+
* @param url url Services
2120
* @param user correo o usuario de SW
2221
* @param password password de SW.
2322
* @param proxy ip o dominio de proxy (null si no se utiliza)
@@ -32,7 +31,7 @@ public CsdUtils(String url, String user, String password, String proxy,
3231
/**
3332
* Constructor de la clase.
3433
*
35-
* @param url url base de la API
34+
* @param url url Services
3635
* @param token token infinito de SW.
3736
* @param proxy ip o dominio de proxy (null si no se utiliza)
3837
* @param proxyPort número de puerto de proxy (cualquier valor si proxy es null)

‎src/main/java/mx/com/sw/services/csd/responses/CsdData.java‎

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -17,35 +17,35 @@ public class CsdData {
1717
* Retorna el RFC del certificado
1818
* @return String
1919
*/
20-
public String getIssuer_rfc() {
20+
public String getIssuerRfc() {
2121
return issuer_rfc;
2222
}
2323

24-
public void setIssuer_rfc(String issuer_rfc) {
24+
public void setIssuerRfc(String issuer_rfc) {
2525
this.issuer_rfc = issuer_rfc;
2626
}
2727

2828
/**
2929
* Retorna el número del certificado
3030
* @return String
3131
*/
32-
public String getCertificate_number() {
32+
public String getCertificateNumber() {
3333
return certificate_number;
3434
}
3535

36-
public void setCertificate_number(String certificate_number) {
36+
public void setCertificateNumber(String certificate_number) {
3737
this.certificate_number = certificate_number;
3838
}
3939

4040
/**
4141
* Retorna el certificado en B64
4242
* @return String
4343
*/
44-
public String getCsd_certificate() {
44+
public String getCsdCertificate() {
4545
return csd_certificate;
4646
}
4747

48-
public void setCsd_certificate(String csd_certificate) {
48+
public void setCsdCertificate(String csd_certificate) {
4949
this.csd_certificate = csd_certificate;
5050
}
5151

@@ -55,47 +55,47 @@ public void setCsd_certificate(String csd_certificate) {
5555
* false
5656
* @return String
5757
*/
58-
public String getIs_active() {
58+
public String getIsActive() {
5959
return is_active;
6060
}
6161

62-
public void setIs_active(String is_active) {
62+
public void setIsActive(String is_active) {
6363
this.is_active = is_active;
6464
}
6565

6666
/**
6767
* Retorna el nombre a quien esta el certificado
6868
* @return String
6969
*/
70-
public String getIssuer_business_name() {
70+
public String getIssuerBusinessName() {
7171
return issuer_business_name;
7272
}
7373

74-
public void setIssuer_business_name(String issuer_business_name) {
74+
public void setIssuerBusinessName(String issuer_business_name) {
7575
this.issuer_business_name = issuer_business_name;
7676
}
7777

7878
/**
7979
* Retorna la fecha desde la cual es valido el certificado
8080
* @return String
8181
*/
82-
public String getValid_from() {
82+
public String getValidFrom() {
8383
return valid_from;
8484
}
8585

86-
public void setValid_from(String valid_from) {
86+
public void setValidFrom(String valid_from) {
8787
this.valid_from = valid_from;
8888
}
8989

9090
/**
9191
* Retorna la fecha hasta la cual es valido el certificado
9292
* @return String
9393
*/
94-
public String getValid_to() {
94+
public String getValidTo() {
9595
return valid_to;
9696
}
9797

98-
public void setValid_to(String valid_to) {
98+
public void setValidTo(String valid_to) {
9999
this.valid_to = valid_to;
100100
}
101101

@@ -104,11 +104,11 @@ public void setValid_to(String valid_to) {
104104
* Default = Stamp
105105
* @return String
106106
*/
107-
public String getCertificate_type() {
107+
public String getCertificateType() {
108108
return certificate_type;
109109
}
110110

111-
public void setCertificate_type(String certificate_type) {
111+
public void setCertificateType(String certificate_type) {
112112
this.certificate_type = certificate_type;
113113
}
114114
}

‎src/test/java/mx/com/sw/services/csd/CsdTest.java‎

Lines changed: 32 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -176,13 +176,14 @@ public void testGetCsd_Success(){
176176
Assertions.assertNotNull(response.getStatus());
177177
Assertions.assertNotNull(response.getData());
178178
Assertions.assertTrue("success".equalsIgnoreCase(response.getStatus()));
179-
System.out.println(response.getData().getIssuer_rfc());
180-
System.out.println(response.getData().getIssuer_business_name());
181-
System.out.println(response.getData().getCertificate_number());
182-
System.out.println(response.getData().getCertificate_type());
183-
System.out.println(response.getData().getIs_active());
184-
System.out.println(response.getData().getValid_from());
185-
System.out.println(response.getData().getValid_to());
179+
System.out.println(response.getData().getIssuerRfc());
180+
System.out.println(response.getData().getIssuerBusinessName());
181+
System.out.println(response.getData().getCertificateNumber());
182+
System.out.println(response.getData().getCsdCertificate());
183+
System.out.println(response.getData().getCertificateType());
184+
System.out.println(response.getData().getIsActive());
185+
System.out.println(response.getData().getValidFrom());
186+
System.out.println(response.getData().getValidTo());
186187
} catch (ServicesException ex) {
187188
Assertions.assertNotNull(ex);
188189
}
@@ -215,13 +216,14 @@ public void testGetCsd_Token_Success(){
215216
Assertions.assertNotNull(response.getStatus());
216217
Assertions.assertNotNull(response.getData());
217218
Assertions.assertTrue("success".equalsIgnoreCase(response.getStatus()));
218-
System.out.println(response.getData().getIssuer_rfc());
219-
System.out.println(response.getData().getIssuer_business_name());
220-
System.out.println(response.getData().getCertificate_number());
221-
System.out.println(response.getData().getCertificate_type());
222-
System.out.println(response.getData().getIs_active());
223-
System.out.println(response.getData().getValid_from());
224-
System.out.println(response.getData().getValid_to());
219+
System.out.println(response.getData().getIssuerRfc());
220+
System.out.println(response.getData().getIssuerBusinessName());
221+
System.out.println(response.getData().getCertificateNumber());
222+
System.out.println(response.getData().getCsdCertificate());
223+
System.out.println(response.getData().getCertificateType());
224+
System.out.println(response.getData().getIsActive());
225+
System.out.println(response.getData().getValidFrom());
226+
System.out.println(response.getData().getValidTo());
225227
} catch (ServicesException ex) {
226228
Assertions.assertNotNull(ex);
227229
}
@@ -256,13 +258,14 @@ public void testGetAllCsd_Success(){
256258
if(lista != null) {
257259
for(int i=0; i<lista.size(); i++) {
258260
CsdData dato = lista.get(i);
259-
System.out.println(dato.getIssuer_rfc());
260-
System.out.println(dato.getIssuer_business_name());
261-
System.out.println(dato.getCertificate_number());
262-
System.out.println(dato.getCertificate_type());
263-
System.out.println(dato.getIs_active());
264-
System.out.println(dato.getValid_from());
265-
System.out.println(dato.getValid_to());
261+
System.out.println(dato.getIssuerRfc());
262+
System.out.println(dato.getIssuerBusinessName());
263+
System.out.println(dato.getCertificateNumber());
264+
System.out.println(dato.getCsdCertificate());
265+
System.out.println(dato.getCertificateType());
266+
System.out.println(dato.getIsActive());
267+
System.out.println(dato.getValidFrom());
268+
System.out.println(dato.getValidTo());
266269
}
267270
}
268271
} catch (ServicesException ex) {
@@ -282,13 +285,14 @@ public void testGetAllCsd_Token_Success(){
282285
if(lista != null) {
283286
for(int i=0; i<lista.size(); i++) {
284287
CsdData dato = lista.get(i);
285-
System.out.println(dato.getIssuer_rfc());
286-
System.out.println(dato.getIssuer_business_name());
287-
System.out.println(dato.getCertificate_number());
288-
System.out.println(dato.getCertificate_type());
289-
System.out.println(dato.getIs_active());
290-
System.out.println(dato.getValid_from());
291-
System.out.println(dato.getValid_to());
288+
System.out.println(dato.getIssuerRfc());
289+
System.out.println(dato.getIssuerBusinessName());
290+
System.out.println(dato.getCertificateNumber());
291+
System.out.println(dato.getCsdCertificate());
292+
System.out.println(dato.getCertificateType());
293+
System.out.println(dato.getIsActive());
294+
System.out.println(dato.getValidFrom());
295+
System.out.println(dato.getValidTo());
292296
}
293297
}
294298
} catch (ServicesException ex) {

0 commit comments

Comments
 (0)