Bump CMake minimal version up to 3.5 #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the docs[1], <cmake_minimum_required> should be called at the beginning of the top-level CMakeLists.txt (even before calling the <project> command) to set the version and the policy settings before invoking other commands whose behavior they may affect. All other calls (especially, setting the same version) are definitely excess. Hence, the patch drops <cmake_minimum_required> calls from all CMakeLists.txt except the root one. [1]: https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html Signed-off-by: Igor Munkin <imun@cpan.org>
According to the docs[1], the FATAL_ERROR option is accepted but ignored by CMake 2.6 and higher. It should be specified so CMake versions 2.4 and lower fail with an error instead of just a warning. Since compatibility with versions of CMake older than 2.8.12 is already deprecated, there is no need to provide this option anymore. [1]: https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html Signed-off-by: Igor Munkin <imun@cpan.org>
According to the docs[1], compatibility with versions of CMake older than 3.5 is deprecated since the version 3.27. Ubuntu 24.04 provides CMake 3.28.3 by default, so uJIT configuration starts spoiling the diagnostics with the following warning: | CMake Deprecation Warning at CMakeLists.txt:11 (cmake_minimum_required): | Compatibility with CMake < 3.5 will be removed from a future version of | CMake. | | Update the VERSION argument <min> value or use a ...<max> suffix to tell | CMake that the project does not need compatibility with older versions. Since there is no particular policies specified in the project CMake machinery, there is no need to stick to the 3.3.2 version. However, migration to the newest version requires more precise changes, so this patch only bumps the minimal required version up to 3.5. [1]: https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html Signed-off-by: Igor Munkin <imun@cpan.org>
CMakeParseArguments module provided <cmake_parse_arguments> command, that is implemented natively since CMake 3.5. As a result, both includes, that are empty placeholders now, can be removed. Signed-off-by: Igor Munkin <imun@cpan.org>
According to the docs[1], IN_LIST operator was introduced in CMake 3.3, but was not used in uJIT CMake machinery previously for some reasons. Anyway, CMake 3.5 is the minimal required version now, so this patch replaces list(FIND ...) hack with IN_LIST operator. It's worth to mention, that there has always been a policy[2] to tweak IN_LIST behaviour, but actually, it produces no warning if it's not set to NEW, so setting this policy is omitted in this patch. [1]: https://cmake.org/cmake/help/latest/command/if.html#in-list [2]: https://cmake.org/cmake/help/v3.3/policy/CMP0057.html Signed-off-by: Igor Munkin <imun@cpan.org>
igelhaus
approved these changes
May 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the docs1, compatibility with versions of CMake older than 3.5 is deprecated since the version 3.27. Ubuntu 24.04 provides CMake 3.28.3 by default, so uJIT configuration starts spoiling the diagnostics with the following warning:
Since there is no particular policies specified in the project CMake machinery, there is no need to stick to the 3.3.2 version. However, migration to the newest version requires more precise changes, so this patch only bumps the minimal required version up to 3.5.
As a result, all explicit includes for
CMakeParseArgumentsmodule have been removed, becausecmake_parse_argumentscommand is implemented natively since CMake 3.5, andlist(FIND ...)hack in the root CMakeLists.txt has been replaced withIN_LISToperator.Besides there are to more tiny changes, related to
cmake_mininum_required.First of all, the
FATAL_ERRORoption is accepted but ignored by CMake 2.6 and higher. It should be specified so CMake versions 2.4 and lower fail with an error instead of just a warning. Since compatibility with versions of CMake older than 2.8.12 is already deprecated, there is no need to provide this option anymore.Furthermore,
cmake_minimum_requiredshould be called at the beginning of the top-level CMakeLists.txt (even before calling theprojectcommand) to set the version and the policy settings before invoking other commands whose behavior they may affect. All other calls (especially, setting the same version) are definitely excess. Hence, the patch dropscmake_minimum_requiredcalls from all CMakeLists.txt except the root one.Signed-off-by: Igor Munkin imun@cpan.org