Fix moving dead slots in FFI finalizers table #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuaVela has the internal weak table to keep the mapping for GCcdata objects to their finalizers, which are set via <ffi.gc>. When GCcdata object becomes dead, there is still the key in this weak table until it's finalized by the Lua garbage collector (more precisely, until the next GCfinalize phase). When the table reallocation occurs, these keys are copied intact to the new hash part. LuaVela uses <copyTV> for such move, but there is just a plain pointer assignment in LuaJIT. As a result, the assertion within <tvchecklive> (to be more precisely within <isdead> check) hits. This patch replaces <copyTV> with the simple pointer move. Relates to tarantool/tarantool#5101 Co-authored-by: Igor Munkin <imun@cpan.org> Signed-off-by: Igor Munkin <imun@cpan.org>
igormunkin
added a commit
that referenced
this pull request
Apr 28, 2025
This patch removes Ubuntu 20.04 (Focal Fossa) from the supported platforms, since GitHub announced its deprecation in GitHub Actions. It became fully unsupported since 2025-04-15, that was discovered by accident in precommit tests for #75. Follows up actions/runner-images#11101 Signed-off-by: Igor Munkin <imun@cpan.org>
igormunkin
force-pushed
the
imun/buristan-fix-lj_tab_newkey-for-dead-slots
branch
2 times, most recently
from
e2f8a3b to
30e7c97
Compare
igelhaus
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LuaVela has the internal weak table to keep the mapping for GCcdata objects to their finalizers, which are set via
ffi.gc. When GCcdata object becomes dead, there is still the key in this weak table until it's finalized by the Lua garbage collector (more precisely, until the next GCfinalize phase). When the table reallocation occurs, these keys are copied intact to the new hash part.LuaVela uses
copyTVfor such move, but there is just a plain pointer assignment in LuaJIT. As a result, the assertion withintvchecklive(to be more precisely withinisdeadcheck) hits.This patch replaces
copyTVwith the simple pointer move.Relates to tarantool/tarantool#5101
Co-authored-by: Igor Munkin imun@cpan.org
Signed-off-by: Igor Munkin imun@cpan.org