Set CMake minimum required version only once

igormunkin · igormunkin · commit 32ca2c087ab2 · 2025-04-30T23:24:08.000+03:00
According to the docs[1], <cmake_minimum_required> should be called at the beginning of the top-level CMakeLists.txt (even before calling the <project> command) to set the version and the policy settings before invoking other commands whose behavior they may affect. All other calls (especially, setting the same version) are definitely excess. Hence, the patch drops <cmake_minimum_required> calls from all CMakeLists.txt except the root one. [1]: https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html Signed-off-by: Igor Munkin <imun@cpan.org>
diff --git a/3rdparty/CMakeLists.txt b/3rdparty/CMakeLists.txt
@@ -2,8 +2,6 @@
 # Copyright (C) 2020-2025 LuaVela Authors. See Copyright Notice in COPYRIGHT
 # Copyright (C) 2015-2020 IPONWEB Ltd. See Copyright Notice in COPYRIGHT
 
-cmake_minimum_required (VERSION 3.3.2 FATAL_ERROR)
-
 include(ExternalProject)
 
 set(THIRD_PARTY_INCLUDE)
diff --git a/etc/CMakeLists.txt b/etc/CMakeLists.txt
@@ -2,8 +2,6 @@
 # Copyright (C) 2020-2025 LuaVela Authors. See Copyright Notice in COPYRIGHT
 # Copyright (C) 2015-2020 IPONWEB Ltd. See Copyright Notice in COPYRIGHT
 
-cmake_minimum_required (VERSION 3.3.2 FATAL_ERROR)
-
 set(UJIT_MAN_PAGE ${CMAKE_CURRENT_SOURCE_DIR}/ujit.1)
 set(UJIT_COMPRESSED_MAN_PAGE ${CMAKE_CURRENT_BINARY_DIR}/ujit.1.gz)
 
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
@@ -2,7 +2,6 @@
 # Copyright (C) 2020-2025 LuaVela Authors. See Copyright Notice in COPYRIGHT
 # Copyright (C) 2015-2020 IPONWEB Ltd. See Copyright Notice in COPYRIGHT
 
-cmake_minimum_required (VERSION 3.3.2 FATAL_ERROR)
 enable_language (ASM)
 
 include_directories(${CMAKE_CURRENT_SOURCE_DIR}) # for sub-projects
diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt
@@ -2,8 +2,6 @@
 # Copyright (C) 2020-2025 LuaVela Authors. See Copyright Notice in COPYRIGHT
 # Copyright (C) 2015-2020 IPONWEB Ltd. See Copyright Notice in COPYRIGHT
 
-cmake_minimum_required (VERSION 3.3.2 FATAL_ERROR)
-
 set(CMAKE_MODULE_PATH
   ${CMAKE_MODULE_PATH} "${CMAKE_CURRENT_SOURCE_DIR}/cmake"
 )
diff --git a/tools/CMakeLists.txt b/tools/CMakeLists.txt
@@ -2,7 +2,6 @@
 # Copyright (C) 2020-2025 LuaVela Authors. See Copyright Notice in COPYRIGHT
 # Copyright (C) 2015-2020 IPONWEB Ltd. See Copyright Notice in COPYRIGHT
 
-cmake_minimum_required (VERSION 3.3.2 FATAL_ERROR)
 enable_language(C)
 
 include(MakeSourceList)

Original file line number	Diff line number	Diff line change
`@@ -2,8 +2,6 @@`
`2`	`2`	`# Copyright (C) 2020-2025 LuaVela Authors. See Copyright Notice in COPYRIGHT`
`3`	`3`	`# Copyright (C) 2015-2020 IPONWEB Ltd. See Copyright Notice in COPYRIGHT`
`4`	`4`
`5`		`-cmake_minimum_required (VERSION 3.3.2 FATAL_ERROR)`
`6`		`-`
`7`	`5`	`set(CMAKE_MODULE_PATH`
`8`	`6`	`${CMAKE_MODULE_PATH} "${CMAKE_CURRENT_SOURCE_DIR}/cmake"`
`9`	`7`	`)`