Support PHP 8 #238
Merged
Support PHP 8 #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phanan
approved these changes
Mar 6, 2021
tests/Functional/AnnotationsTest.php
Outdated
| use ReflectionFunction; | ||
|
|
||
| use function Functional\group; | ||
| use function get_defined_functions; |
Collaborator
There was a problem hiding this comment.
Do we or do we not import the root namespaced functions? It looks like a mix at the moment.
Owner
Author
There was a problem hiding this comment.
It’s a mess, yeah. Functional shows it's age here (I just realized when updating the copyright notice it’s 10 years anniversary). When it started, use function … was not a thing. But yes, it should be imported everywhere.
Edit: I misread the question.
To the actual question: no, we backslash-ref import them. php-cs-fixer does it consistently for us. Still want to add php-cs-fixer to CI.
Co-authored-by: Phan An <me@phanan.net>
Co-authored-by: Phan An <me@phanan.net>
Owner
Author
Good point, done |
This was referenced Mar 7, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for PHP 8 based on @phanan’s PR #236
Todos:
AbstractTestCase::expectArgumentErrormethod to adapt to the new message format thrown in PHP 8 (actually, create a new method altogether).