Test enhancement #228
Closed
Test enhancement #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter279k
commented
Nov 18, 2020
| $this->assertSame('methodValue', invoke_first($this->listIterator, 'method')); | ||
| $this->assertSame(null, invoke_first($this->list, 'undefinedMethod')); | ||
| $this->assertSame(null, invoke_first($this->list, 'setExpectedExceptionFromAnnotation'), 'Protected method'); | ||
| $this->assertNull(invoke_first($this->list, 'undefinedMethod')); |
Contributor
Author
There was a problem hiding this comment.
It should use the assertNull to assert expected is null.
peter279k
commented
Nov 18, 2020
| $this->assertSame('methodValue', invoke_first($this->iteratorVeryFirstNotCallable, 'method')); | ||
| $this->assertSame(null, invoke_first($this->arrayVeryFirstNotCallable, 'undefinedMethod')); | ||
| $this->assertSame(null, invoke_first($this->arrayVeryFirstNotCallable, 'setExpectedExceptionFromAnnotation'), 'Protected method'); | ||
| $this->assertNull(invoke_first($this->arrayVeryFirstNotCallable, 'undefinedMethod')); |
Contributor
Author
There was a problem hiding this comment.
It should use the assertNull to assert expected is null.
peter279k
commented
Nov 18, 2020
| $this->assertSame('methodValue', invoke_last($this->listIterator, 'method')); | ||
| $this->assertSame(null, invoke_last($this->list, 'undefinedMethod')); | ||
| $this->assertSame(null, invoke_last($this->list, 'setExpectedExceptionFromAnnotation'), 'Protected method'); | ||
| $this->assertNull(invoke_last($this->list, 'undefinedMethod')); |
Contributor
Author
There was a problem hiding this comment.
It should use the assertNull to assert expected is null.
peter279k
commented
Nov 18, 2020
| $this->assertSame('2', pick($this->array_1, 'two')); | ||
| $this->assertSame( | ||
| null, | ||
| $this->assertNull( |
Contributor
Author
There was a problem hiding this comment.
It should use the assertNull to assert expected is null.
peter279k
commented
Nov 18, 2020
| $this->assertSame(':)', pick($this->array_1, 'zero-index', ':)', $customCallback)); | ||
| $this->assertSame('0', pick($this->array_1, 'zero-string-index', ':)', $customCallback)); | ||
| $this->assertSame(false, pick($this->array_1, 'false-index', ':)', $customCallback)); | ||
| $this->assertFalse(pick($this->array_1, 'false-index', ':)', $customCallback)); |
Contributor
Author
There was a problem hiding this comment.
It should use the assertFalse to assert expected is false.
lstrojny
approved these changes
Dec 16, 2020
Owner
lstrojny
left a comment
lstrojny
left a comment
There was a problem hiding this comment.
Looks good, thank you! Can you fix the composer conflict so I can merge?
Contributor
Author
|
There're many conflicts to be concerned. I decide to close this PR and create another one :). |
peter279k
added a commit
to open-source-contributions/functional-php
that referenced
this pull request
Mar 7, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed log
php-7.1version at least, and it should modify semver version oncomposer.jsonfile.protected function setUp(): void.