Make default callback the identity function. #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Looks good, thank you! Could you update the docs as well? I've commented on #212 wrt to reject/select |
This commit changes the `select`, `reject`, `some`, `none`, and `every` functions so that the default callback argument is the `id` function.
jasonmm
force-pushed
the
default-callbacks
branch
from
dd658db to
cd2b718
Compare
Contributor
Author
|
The file docs/functional-php.md and the functions' docstrings have been updated. Changes to |
lstrojny
requested changes
Mar 27, 2020
Owner
lstrojny
left a comment
lstrojny
left a comment
There was a problem hiding this comment.
Looks good, just three editorial questions
docs/functional-php.md
Outdated
| } | ||
| ``` | ||
|
|
||
| The default value for $callback is `id()`. |
Owner
There was a problem hiding this comment.
Can you elaborate on thwat that means? Like "Will return true if every value in the collection is truthy"
docs/functional-php.md
Outdated
| } | ||
| ``` | ||
|
|
||
| The default value for $callback is `id()`. |
Owner
There was a problem hiding this comment.
A bit elaboration would be nice here as well
docs/functional-php.md
Outdated
| } | ||
| ``` | ||
|
|
||
| The default value for $callback is `id()`. |
Owner
There was a problem hiding this comment.
A bit elaboration would be nice here as well
Contributor
Author
|
Thanks for the suggestions! The docs were updated in 8a23e41. Let me know if further refinement is necessary. |
lstrojny
approved these changes
Mar 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
select,reject,some,none, andeveryfunctions so that the default callback argument is theidfunction.PHP allows only
nullto be set as the default value of acallableargument. This requires a null check in the body of each function.