feat: add warning message when adding duplicate skeleton

liujuping · JackLian · commit e415ff678206 · 2022-12-30T17:49:05.000+08:00
diff --git a/packages/editor-skeleton/src/area.ts b/packages/editor-skeleton/src/area.ts
@@ -1,9 +1,12 @@
 /* eslint-disable max-len */
 import { obx, computed, makeObservable } from '@alilc/lowcode-editor-core';
+import { Logger } from '@alilc/lowcode-utils';
+import { IPublicTypeWidgetBaseConfig, IArea } from '@alilc/lowcode-types';
 import { WidgetContainer } from './widget/widget-container';
 import { Skeleton } from './skeleton';
 import { IWidget } from './widget/widget';
-import { IPublicTypeWidgetBaseConfig, IArea } from '@alilc/lowcode-types';
+
+const logger = new Logger({ level: 'warn', bizName: 'skeleton:area' });
 
 export class Area<C extends IPublicTypeWidgetBaseConfig = any, T extends IWidget = IWidget> implements IArea<C, T> {
   @obx private _visible = true;
@@ -36,6 +39,7 @@ export class Area<C extends IPublicTypeWidgetBaseConfig = any, T extends IWidget
   add(config: T | C): T {
     const item = this.container.get(config.name);
     if (item) {
+      logger.warn(`The ${config.name} has already been added to skeleton.`);
       return item;
     }
     return this.container.add(config);
diff --git a/packages/shell/src/api/skeleton.ts b/packages/shell/src/api/skeleton.ts
@@ -11,7 +11,7 @@ export class Skeleton implements IPublicApiSkeleton {
   private readonly [innerSkeletonSymbol]: InnerSkeleton;
   private readonly pluginName: string;
 
-  get [skeletonSymbol]() {
+  get [skeletonSymbol](): InnerSkeleton {
     if (this.workspaceMode) {
       return this[innerSkeletonSymbol];
     }

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ export class Skeleton implements IPublicApiSkeleton {`
`11`	`11`	`private readonly [innerSkeletonSymbol]: InnerSkeleton;`
`12`	`12`	`private readonly pluginName: string;`
`13`	`13`
`14`		`- get [skeletonSymbol]() {`
	`14`	`+ get [skeletonSymbol](): InnerSkeleton {`
`15`	`15`	`if (this.workspaceMode) {`
`16`	`16`	`return this[innerSkeletonSymbol];`
`17`	`17`	`}`