Skip to content

Commit c247efe

Browse files
jayschwaMicah Lee
jayschwa
authored and
Micah Lee
committed
Fix style in Chrome extension
The extension previously loaded CSS from chrome://resources so that it would have a style consistent with the rest of Chrome. However, extensions are no longer permitted to load resources from chrome://. Local copies of chrome_shared.css and widgets.css have been added from https://src.chromium.org/chrome/trunk/src/ui/webui/resources/css This solution seems less than ideal, but it's the same approach Google used for some of their example extensions.
1 parent 2d10765 commit c247efe

File tree

5 files changed

+426
-2
lines changed

5 files changed

+426
-2
lines changed

‎chromium/chrome-resources/css/chrome_shared.css‎

Lines changed: 106 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,106 @@
1+
/* Copyright (c) 2012 The Chromium Authors. All rights reserved.
2+
* Use of this source code is governed by a BSD-style license that can be
3+
* found in the LICENSE file. */
4+
5+
/* This file holds CSS that should be shared, in theory, by all user-visible
6+
* chrome:// pages. */
7+
8+
@import url("widgets.css");
9+
<if expr="pp_ifdef('chromeos')">
10+
@import url("chromeos/ui_account_tweaks.css");
11+
</if>
12+
13+
/* Prevent CSS from overriding the hidden property. */
14+
[hidden] {
15+
display: none !important;
16+
}
17+
18+
html.loading * {
19+
-webkit-transition-delay: 0 !important;
20+
-webkit-transition-duration: 0 !important;
21+
}
22+
23+
body {
24+
cursor: default;
25+
margin: 0;
26+
}
27+
28+
p {
29+
line-height: 1.8em;
30+
}
31+
32+
h1,
33+
h2,
34+
h3 {
35+
-webkit-user-select: none;
36+
font-weight: normal;
37+
/* Makes the vertical size of the text the same for all fonts. */
38+
line-height: 1;
39+
}
40+
41+
h1 {
42+
font-size: 1.5em;
43+
}
44+
45+
h2 {
46+
font-size: 1.3em;
47+
margin-bottom: 0.4em;
48+
}
49+
50+
h3 {
51+
color: black;
52+
font-size: 1.2em;
53+
margin-bottom: 0.8em;
54+
}
55+
56+
a {
57+
color: rgb(17, 85, 204);
58+
text-decoration: underline;
59+
}
60+
61+
a:active {
62+
color: rgb(5, 37, 119);
63+
}
64+
65+
/* Elements that need to be LTR even in an RTL context, but should align
66+
* right. (Namely, URLs, search engine names, etc.)
67+
*/
68+
html[dir='rtl'] .weakrtl {
69+
direction: ltr;
70+
text-align: right;
71+
}
72+
73+
/* Input fields in search engine table need to be weak-rtl. Since those input
74+
* fields are generated for all cr.ListItem elements (and we only want weakrtl
75+
* on some), the class needs to be on the enclosing div.
76+
*/
77+
html[dir='rtl'] div.weakrtl input {
78+
direction: ltr;
79+
text-align: right;
80+
}
81+
82+
html[dir='rtl'] .favicon-cell.weakrtl {
83+
-webkit-padding-end: 22px;
84+
-webkit-padding-start: 0;
85+
}
86+
87+
/* weakrtl for selection drop downs needs to account for the fact that
88+
* Webkit does not honor the text-align attribute for the select element.
89+
* (See Webkit bug #40216)
90+
*/
91+
html[dir='rtl'] select.weakrtl {
92+
direction: rtl;
93+
}
94+
95+
html[dir='rtl'] select.weakrtl option {
96+
direction: ltr;
97+
}
98+
99+
/* WebKit does not honor alignment for text specified via placeholder attribute.
100+
* This CSS is a workaround. Please remove once WebKit bug is fixed.
101+
* https://bugs.webkit.org/show_bug.cgi?id=63367
102+
*/
103+
html[dir='rtl'] input.weakrtl::-webkit-input-placeholder,
104+
html[dir='rtl'] .weakrtl input::-webkit-input-placeholder {
105+
direction: rtl;
106+
}

0 commit comments

Comments
 (0)