Skip to content

Commit 99fe9fd

Browse files
jbgijbgi
committed
Make methods that are not meant to be overriden final.
1 parent d334542 commit 99fe9fd

File tree

32 files changed

+348
-346
lines changed

32 files changed

+348
-346
lines changed

‎core/src/main/java/fj/F1W.java‎

Lines changed: 69 additions & 69 deletions
Large diffs are not rendered by default.

‎core/src/main/java/fj/F2W.java‎

Lines changed: 27 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ public abstract class F2W<A, B, C> implements F2<A, B, C> {
1414
* @param a The <code>A</code> to which to apply this function.
1515
* @return The function partially applied to the given argument.
1616
*/
17-
public F1W<B, C> f(final A a) {
17+
public final F1W<B, C> f(final A a) {
1818
return F1W.lift(F2Functions.f(this, a));
1919
}
2020

@@ -23,7 +23,7 @@ public F1W<B, C> f(final A a) {
2323
*
2424
* @return a wrapped function of arity-1 that returns another wrapped function.
2525
*/
26-
public F1W<A, F<B, C>> curry() {
26+
public final F1W<A, F<B, C>> curry() {
2727
return F1W.lift(F2Functions.curry(this));
2828
}
2929

@@ -32,7 +32,7 @@ public F1W<A, F<B, C>> curry() {
3232
*
3333
* @return A new function with the arguments of this function flipped.
3434
*/
35-
public F2W<B, A, C> flip() {
35+
public final F2W<B, A, C> flip() {
3636
return lift(F2Functions.flip(this));
3737
}
3838

@@ -41,7 +41,7 @@ public F2W<B, A, C> flip() {
4141
*
4242
* @return A new function that calls this function with the elements of a given tuple.
4343
*/
44-
public F1W<P2<A, B>, C> tuple() {
44+
public final F1W<P2<A, B>, C> tuple() {
4545
return F1W.lift(F2Functions.tuple(this));
4646
}
4747

@@ -50,7 +50,7 @@ public F1W<P2<A, B>, C> tuple() {
5050
*
5151
* @return This function promoted to transform Arrays.
5252
*/
53-
public F2W<Array<A>, Array<B>, Array<C>> arrayM() {
53+
public final F2W<Array<A>, Array<B>, Array<C>> arrayM() {
5454
return lift(F2Functions.arrayM(this));
5555
}
5656

@@ -59,7 +59,7 @@ public F2W<Array<A>, Array<B>, Array<C>> arrayM() {
5959
*
6060
* @return This function promoted to transform Promises.
6161
*/
62-
public F2W<Promise<A>, Promise<B>, Promise<C>> promiseM() {
62+
public final F2W<Promise<A>, Promise<B>, Promise<C>> promiseM() {
6363
return lift(F2Functions.promiseM(this));
6464
}
6565

@@ -68,7 +68,7 @@ public F2W<Promise<A>, Promise<B>, Promise<C>> promiseM() {
6868
*
6969
* @return This function promoted to transform Iterables.
7070
*/
71-
public F2W<Iterable<A>, Iterable<B>, IterableW<C>> iterableM() {
71+
public final F2W<Iterable<A>, Iterable<B>, IterableW<C>> iterableM() {
7272
return lift(F2Functions.iterableM(this));
7373
}
7474

@@ -77,7 +77,7 @@ public F2W<Iterable<A>, Iterable<B>, IterableW<C>> iterableM() {
7777
*
7878
* @return This function promoted to transform Lists.
7979
*/
80-
public F2W<List<A>, List<B>, List<C>> listM() {
80+
public final F2W<List<A>, List<B>, List<C>> listM() {
8181
return lift(F2Functions.listM(this));
8282
}
8383

@@ -86,7 +86,7 @@ public F2W<List<A>, List<B>, List<C>> listM() {
8686
*
8787
* @return This function promoted to transform non-empty lists.
8888
*/
89-
public F2W<NonEmptyList<A>, NonEmptyList<B>, NonEmptyList<C>> nelM() {
89+
public final F2W<NonEmptyList<A>, NonEmptyList<B>, NonEmptyList<C>> nelM() {
9090
return lift(F2Functions.nelM(this));
9191
}
9292

@@ -95,7 +95,7 @@ public F2W<NonEmptyList<A>, NonEmptyList<B>, NonEmptyList<C>> nelM() {
9595
*
9696
* @return This function promoted to transform Options.
9797
*/
98-
public F2W<Option<A>, Option<B>, Option<C>> optionM() {
98+
public final F2W<Option<A>, Option<B>, Option<C>> optionM() {
9999
return lift(F2Functions.optionM(this));
100100
}
101101

@@ -105,7 +105,7 @@ public F2W<Option<A>, Option<B>, Option<C>> optionM() {
105105
* @param o An ordering for the result of the promoted function.
106106
* @return This function promoted to transform Sets.
107107
*/
108-
public F2W<Set<A>, Set<B>, Set<C>> setM(final Ord<C> o) {
108+
public final F2W<Set<A>, Set<B>, Set<C>> setM(final Ord<C> o) {
109109
return lift(F2Functions.setM(this, o));
110110
}
111111

@@ -114,7 +114,7 @@ public F2W<Set<A>, Set<B>, Set<C>> setM(final Ord<C> o) {
114114
*
115115
* @return This function promoted to transform Streams.
116116
*/
117-
public F2W<Stream<A>, Stream<B>, Stream<C>> streamM() {
117+
public final F2W<Stream<A>, Stream<B>, Stream<C>> streamM() {
118118
return lift(F2Functions.streamM(this));
119119
}
120120

@@ -123,7 +123,7 @@ public F2W<Stream<A>, Stream<B>, Stream<C>> streamM() {
123123
*
124124
* @return This function promoted to transform Trees.
125125
*/
126-
public F2W<Tree<A>, Tree<B>, Tree<C>> treeM() {
126+
public final F2W<Tree<A>, Tree<B>, Tree<C>> treeM() {
127127
return lift(F2Functions.treeM(this));
128128
}
129129

@@ -132,7 +132,7 @@ public F2W<Tree<A>, Tree<B>, Tree<C>> treeM() {
132132
*
133133
* @return A function that zips two arrays with this function.
134134
*/
135-
public F2W<Array<A>, Array<B>, Array<C>> zipArrayM() {
135+
public final F2W<Array<A>, Array<B>, Array<C>> zipArrayM() {
136136
return lift(F2Functions.zipArrayM(this));
137137
}
138138

@@ -141,7 +141,7 @@ public F2W<Array<A>, Array<B>, Array<C>> zipArrayM() {
141141
*
142142
* @return A function that zips two iterables with this function.
143143
*/
144-
public F2W<Iterable<A>, Iterable<B>, Iterable<C>> zipIterableM() {
144+
public final F2W<Iterable<A>, Iterable<B>, Iterable<C>> zipIterableM() {
145145
return lift(F2Functions.zipIterableM(this));
146146
}
147147

@@ -150,7 +150,7 @@ public F2W<Iterable<A>, Iterable<B>, Iterable<C>> zipIterableM() {
150150
*
151151
* @return A function that zips two lists with this function.
152152
*/
153-
public F2W<List<A>, List<B>, List<C>> zipListM() {
153+
public final F2W<List<A>, List<B>, List<C>> zipListM() {
154154
return lift(F2Functions.zipListM(this));
155155
}
156156

@@ -160,7 +160,7 @@ public F2W<List<A>, List<B>, List<C>> zipListM() {
160160
*
161161
* @return A function that zips two streams with this function.
162162
*/
163-
public F2W<Stream<A>, Stream<B>, Stream<C>> zipStreamM() {
163+
public final F2W<Stream<A>, Stream<B>, Stream<C>> zipStreamM() {
164164
return lift(F2Functions.zipStreamM(this));
165165
}
166166

@@ -169,7 +169,7 @@ public F2W<Stream<A>, Stream<B>, Stream<C>> zipStreamM() {
169169
*
170170
* @return A function that zips two non-empty lists with this function.
171171
*/
172-
public F2W<NonEmptyList<A>, NonEmptyList<B>, NonEmptyList<C>> zipNelM() {
172+
public final F2W<NonEmptyList<A>, NonEmptyList<B>, NonEmptyList<C>> zipNelM() {
173173
return lift(F2Functions.zipNelM(this));
174174
}
175175

@@ -179,7 +179,7 @@ public F2W<NonEmptyList<A>, NonEmptyList<B>, NonEmptyList<C>> zipNelM() {
179179
* @param o An ordering for the resulting set.
180180
* @return A function that zips two sets with this function.
181181
*/
182-
public F2W<Set<A>, Set<B>, Set<C>> zipSetM(final Ord<C> o) {
182+
public final F2W<Set<A>, Set<B>, Set<C>> zipSetM(final Ord<C> o) {
183183
return lift(F2Functions.zipSetM(this, o));
184184
}
185185

@@ -189,7 +189,7 @@ public F2W<Set<A>, Set<B>, Set<C>> zipSetM(final Ord<C> o) {
189189
*
190190
* @return A function that zips two trees with this function.
191191
*/
192-
public F2W<Tree<A>, Tree<B>, Tree<C>> zipTreeM() {
192+
public final F2W<Tree<A>, Tree<B>, Tree<C>> zipTreeM() {
193193
return lift(F2Functions.zipTreeM(this));
194194
}
195195

@@ -199,7 +199,7 @@ public F2W<Tree<A>, Tree<B>, Tree<C>> zipTreeM() {
199199
*
200200
* @return A function that zips two zippers with this function.
201201
*/
202-
public F2W<Zipper<A>, Zipper<B>, Zipper<C>> zipZipperM() {
202+
public final F2W<Zipper<A>, Zipper<B>, Zipper<C>> zipZipperM() {
203203
return lift(F2Functions.zipZipperM(this));
204204
}
205205

@@ -209,23 +209,23 @@ public F2W<Zipper<A>, Zipper<B>, Zipper<C>> zipZipperM() {
209209
*
210210
* @return A function that zips two TreeZippers with this function.
211211
*/
212-
public F2W<TreeZipper<A>, TreeZipper<B>, TreeZipper<C>> zipTreeZipperM() {
212+
public final F2W<TreeZipper<A>, TreeZipper<B>, TreeZipper<C>> zipTreeZipperM() {
213213
return lift(F2Functions.zipTreeZipperM(this));
214214
}
215215

216-
public <Z> F2W<Z, B, C> contramapFirst(F<Z, A> f) {
216+
public final <Z> F2W<Z, B, C> contramapFirst(F<Z, A> f) {
217217
return lift(F2Functions.contramapFirst(this, f));
218218
}
219219

220-
public <Z> F2W<A, Z, C> contramapSecond(F<Z, B> f) {
220+
public final <Z> F2W<A, Z, C> contramapSecond(F<Z, B> f) {
221221
return lift(F2Functions.contramapSecond(this, f));
222222
}
223223

224-
public <X, Y> F2W<X, Y, C> contramap(F<X, A> f, F<Y, B> g) {
224+
public final <X, Y> F2W<X, Y, C> contramap(F<X, A> f, F<Y, B> g) {
225225
return lift(F2Functions.contramap(this, f, g));
226226
}
227227

228-
public <Z> F2W<A, B, Z> map(F<C, Z> f) {
228+
public final <Z> F2W<A, B, Z> map(F<C, Z> f) {
229229
return lift(F2Functions.map(this, f));
230230
}
231231

@@ -237,7 +237,7 @@ public F2WFunc(F2<A, B, C> f) {
237237
}
238238

239239
@Override
240-
public C f(A a, B b) {
240+
public final C f(A a, B b) {
241241
return func.f(a, b);
242242
}
243243
}

‎core/src/main/java/fj/LcgRng.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,18 +17,18 @@ public LcgRng(long s) {
1717
seed = s;
1818
}
1919

20-
public long getSeed() {
20+
public final long getSeed() {
2121
return seed;
2222
}
2323

24-
public P2<Rng, Integer> nextInt() {
24+
public final P2<Rng, Integer> nextInt() {
2525
P2<Rng, Long> p = nextLong();
2626
int i = (int) p._2().longValue();
2727
return P.p(p._1(), i);
2828
}
2929

3030

31-
public P2<Rng, Long> nextLong() {
31+
public final P2<Rng, Long> nextLong() {
3232
P2<Long, Long> p = nextLong(seed);
3333
return P.p(new LcgRng(p._1()), p._2());
3434
}

‎core/src/main/java/fj/Ord.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -527,7 +527,7 @@ public static <A> Ord<A> hashEqualsOrd() {
527527

528528
class OrdComparator implements Comparator<A> {
529529
@Override
530-
public int compare(A o1, A o2) {
530+
public final int compare(A o1, A o2) {
531531
return Ord.this.compare(o1, o2).toInt();
532532
}
533533
}

0 commit comments

Comments
 (0)