fix: make filter work on count for consistency#10859
Draft
aaqilniz wants to merge 1 commit intoloopbackio:masterfrom
Draft
fix: make filter work on count for consistency#10859aaqilniz wants to merge 1 commit intoloopbackio:masterfrom
aaqilniz wants to merge 1 commit intoloopbackio:masterfrom
Conversation
Signed-off-by: Muhammad Aaqil <aaqilcs102@gmail.com>
Contributor
Author
|
Hi, @dhmlau. Can you please have a look at this PR? |
Member
|
@aaqilniz, I haven't reviewed the changes yet. but could you please look into the CI failure first? Thanks. |
Contributor
Author
|
Hi, @dhmlau. The tests are failing while publishing coverage reports are being published to Coversall. Everything else before is passing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
countendpoint generated with rest-crud has a where filter but doesn't havefilteritself.So
GET /count?where={"name":<name>}would work butGET /count?filter={"where":{"name":<name>}}will not work.I think this is intentional as the count endpoint would only require a where clause. But this causes inconsistency of filter in GET /count and
GET /andPATCH /.I am creating this draft PR to discuss if we add
filterto/counttoo in order to make it consistent with other endpoints.Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈