Conversation
Member
|
I am rather confused, I would swear I have already created this branch back in December, when I was starting 3.0 development on master. @superkhau please take a look at other commits on the master branch since Dec 22nd, I think some of them should be back-ported - e.g. 93c9f63 via #809. |
Contributor
|
Hi @bajtos, Simon and I cherry-picked #815 into Thanks :-) |
Contributor
Author
This reverts commit 62de2ed.
Add `isNewInstance:false` to the context reported by DAO.updateAttributes()
* Refactor `updateAttributes` (Amir Jafarian) * Enhance "persisted" hook in DAO.updateAttributes (Miroslav Bajtoš) * Add unit test to verify fix for #754 (Tom Kirkpatrick) * Implement `findOrCreate` for memory connector (Amir Jafarian) * Fix a bug when validation is off for findOrCreate (Amir Jafarian) * Fix broken code fencings in the docs (Farid Nouri Neshat) * Revert "Correct syntax for should and more" (Simon Ho) * Fix test for shouldjs 8.0.2 upgrade (Simon Ho) * Upgrade shouldjs to 8.0.2 (Simon Ho) * Correct syntax for should and more (Amir Jafarian)
This includes: *implementation of replaceAttributes *implementtaion of replaceOrCreate
Fix missing connector error msg for db2, cloudant for 2.x
- drop custom findOrCreate implementation - memory connector provides an atomic implementation out of the box now - add new methods `replaceOrCreate` and `replaceByID` - fix error reporting to include the stack trace in the console output [back-port of pull request #847]
[Back-port pull request #859]
Remove next tag (2.x)
*Fix Mongo compatibility issue for replaceOrCreate
Relicense as MIT only
* Insert copyright headers (Miroslav Bajtoš) * Relicense as MIT only (Miroslav Bajtoš) * Fix Mongo compatibility issue (Amir Jafarian) * Add automigrate to setup tables for replace test cases (Amir Jafarian) * Remove next tag (2.x) (Amir Jafarian) * Allow test folder to be published (Amir Jafarian) * Fix tests for mysql (Amir Jafarian) * Add forgotten unit test (Miroslav Bajtoš) * Improve error message on connector init error (Miroslav Bajtoš) * Update describe-operation-hooks (Miroslav Bajtoš) * Fix missing connector error msg for db2, cloudant for 2.x (Candy) * Implementtaion of replace (Amir Jafarian)
*Define `patchOrCreate` as an alias for `updateOrCreate` *Define `PatchAttributes` as an alias for `updateAttributes`
test: extract helpers used in tests for operation hooks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE/CLOSE
This is the official branch for 2.x backports.