Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: loopbackio/loopback-connector-postgresql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.4.0
Choose a base ref
...
head repository: loopbackio/loopback-connector-postgresql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v5.5.1
Choose a head ref
  • 14 commits
  • 16 files changed
  • 6 contributors

Commits on Jul 4, 2021

  1. Defensively drop constraints during migrations

    When `PostgreSQL.prototype.getDropForeignKeys` gets called with
    duplicated foreign keys, an invalid `ALTER TABLE` statement gets
    created. This is because the duplicates are mapped to multiple `DROP
    CONSTRAINT fk_key` SQL actions, e.g.:
    
    ```sql
    -- This will throw an error
    ALTER TABLE "public"."foo"
      DROP CONSTRAINT "fk_duplicatedKey",
      DROP CONSTRAINT "fk_duplicatedKey",
      DROP CONSTRAINT "fk_duplicatedKey",
      DROP CONSTRAINT "fk_otherKey"
    ```
    
    As the `DROP CONSTRAINT` actions are run sequentially, when the first
    action gets executed by PostgreSQL, the next one (for the same, but
    already dropped key) will not cause an SQL error thanks to the added IF
    EXISTS check:
    
    ```sql
    -- This is valid SQL
    ALTER TABLE "public"."foo"
      DROP CONSTRAINT IF EXISTS "fk_duplicatedKey",
      DROP CONSTRAINT IF EXISTS "fk_duplicatedKey",
      DROP CONSTRAINT IF EXISTS "fk_duplicatedKey",
      DROP CONSTRAINT IF EXISTS "fk_otherKey"
    ```
    
    Please note, this is really a hack and we still need to understand why
    the method in question gets called with duplicated foreign keys in
    certain conditions.
    
    Signed-off-by: Chris Kobrzak <chris.kobrzak@gmail.com>
    chris-kobrzak committed Jul 4, 2021
    Configuration menu
    Copy the full SHA
    49b7614 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2021

  1. chore: move repo to loopbackio org

    Signed-off-by: Diana Lau <dhmlau@ca.ibm.com>
    dhmlau committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    a2b3c30 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2021

  1. Merge pull request #480 from chris-kobrzak/master

    Defensively drop constraints during migrations
    dhmlau authored Jul 13, 2021
    Configuration menu
    Copy the full SHA
    edc9c80 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2021

  1. Merge pull request #481 from loopbackio/openjsf

    chore: move repo to loopbackio org
    dhmlau authored Jul 14, 2021
    Configuration menu
    Copy the full SHA
    051098d View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2021

  1. feat(operators): add fts match operator

    Signed-off-by: Akshat  Dubey <akshat.dubey@sourcefuse.com>
    akshatdubeysf authored and achrinza committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    ce2310e View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2021

  1. fix: disregard empty and/or fields

    Signed-off-by: Abhilash Murthy <abhilashmurthy92@gmail.com>
    abhilashmurthy authored and dhmlau committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    ecf91b5 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2021

  1. chore: add Rifa and Mario as codeowners

    Signed-off-by: Diana Lau <dhmlau@ca.ibm.com>
    dhmlau committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    fb87b13 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2022

  1. 5.5.0

     * chore: add Rifa and Mario as codeowners (Diana Lau)
     * fix: disregard empty and/or fields (Abhilash Murthy)
     * feat(operators): add fts match operator (Akshat  Dubey)
     * chore: move repo to loopbackio org (Diana Lau)
     * Defensively drop constraints during migrations (Chris Kobrzak)
    dhmlau committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    96e78db View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2022

  1. docs: add code of conduct

    Signed-off-by: Diana Lau <dhmlau@ca.ibm.com>
    dhmlau committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    b677532 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2022

  1. docs: update coc

    Signed-off-by: Diana Lau <dhmlau@ca.ibm.com>
    dhmlau committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    aa93d13 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2022

  1. docs: add SECURITY.md

    Signed-off-by: Diana Lau <dhmlau@ca.ibm.com>
    dhmlau committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    61b5029 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2022

  1. fix: debug prints the password in plain text

    Signed-off-by: Francisco Buceta <frbuceta@gmail.com>
    frbuceta committed May 23, 2022
    Configuration menu
    Copy the full SHA
    1a863f3 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2022

  1. fix: improve filter sanitisation

    Add sanitisation of user-input for `contains` LoopBack filter which may allow for arbitrary SQL injection.
    
    Signed-off-by: Rifa Achrinza <25147899+achrinza@users.noreply.github.com>
    achrinza committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    d57406c View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2022

  1. 5.5.1

     * fix: improve filter sanitisation (Rifa Achrinza)
    
     * fix: debug prints the password in plain text (Francisco Buceta)
    
     * docs: add SECURITY.md (Diana Lau)
    
     * docs: update coc (Diana Lau)
    
     * docs: add code of conduct (Diana Lau)
    
    Signed-off-by: Rifa Achrinza <25147899+achrinza@users.noreply.github.com>
    achrinza committed Aug 6, 2022
    Configuration menu
    Copy the full SHA
    c684889 View commit details
    Browse the repository at this point in the history
Loading