Change api_key config type to password to prevent from leaks in debug logs. #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roaksoax
suggested changes
May 25, 2023
roaksoax
left a comment
roaksoax
left a comment
There was a problem hiding this comment.
Please add (at least) one tests that makes sure that when setting this config option, the value is of password type.
roaksoax
suggested changes
May 25, 2023
roaksoax
left a comment
roaksoax
left a comment
There was a problem hiding this comment.
Please add (at least) one tests that makes sure that when setting this config option, the value is of password type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running Logstash with
--config.debug,api_keymay be leaked in the debug logs. This PR changesapi_keytype topasswordto prevent from leaks.api_keyconfig can be leaked in debug mode. #7