Skip to content

Conversation

@yaauie
Copy link
Contributor

@yaauie yaauie commented Sep 4, 2018

No description provided.

@jsvd
Copy link
Member

jsvd commented Sep 5, 2018

@jsvd
Copy link
Member

jsvd commented Sep 5, 2018

for now removing this from jarvis queue unti we understand the reasons for ci failing

@yaauie
Copy link
Contributor Author

yaauie commented Sep 6, 2018

One of the failures is definitely a race condition in the rspec mocks that I had thought that I had eliminated, but is apparently still present.

I think the other one is too.

I'll see if I can mitigate. Testing concurrency is hard when RSpec isn't threadsafe.

@yaauie
Copy link
Contributor Author

yaauie commented Sep 6, 2018

I'm holding off on merging until I can finish chasing down the race condition. I am confident that it exists only in specs (the validation of partial mocks created with expect(x).to receive(y)... is not threadsafe), but am adverse to having flaky specs.

@yaauie
Copy link
Contributor Author

yaauie commented Sep 14, 2018

Failures here are due to rspec/rspec-mocks#1236 and will remain intermittent until that fix makes its way to a release. I have not found a way to completely eliminate without solving the underlying bug in rspec, so I will continue to chase that down.

@kares kares closed this Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants