fix: don't crash the UI on unreadable simple queries - #13007
Open
Pandry wants to merge 1 commit into
Open
Conversation
A query containing a token the edn reader rejects, e.g. an auto-resolved keyword typo like (between [[2020-01-01]] ::today), threw from query-dsl/parse. The query builder component renders inline for #Query blocks and calls parse-query outside any error handling, so the reader exception took down the whole React tree and left the graph unusable. Read the query string with common-util/safe-read-string, like every other query-string read site, so unreadable input yields an empty query (the invalid-query result callers already handle) while unexpected errors keep bubbling to the block-level error boundaries.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A query containing a token the edn reader rejects (like an auto-resolved keyword typo like
(between [[2020-01-01]] ::today)), threw fromquery-dsl/parse.The query builder component renders inline for
#Queryblocks and calls parse-query outside any error handling, so the reader exception took down the whole React tree and left the graph unusable.Read the query string with common-util/safe-read-string, like every other query-string read site, so unreadable input yields an empty query (the invalid-query result callers already handle) while unexpected errors keep bubbling to the block-level error boundaries.
Addresses #12926
The writing of this code was assisted by LLM (especially the test, as I don't know Clojure as much), so please double-check it. I made sure to read it and I think I understand it.