fix(editor/db): dead-key composition on international keyboard layouts - #12927
Open
hildersantos wants to merge 1 commit into
Open
fix(editor/db): dead-key composition on international keyboard layouts#12927hildersantos wants to merge 1 commit into
hildersantos wants to merge 1 commit into
Conversation
|
|
On layouts where ` ~ ^ are dead keys (macOS BR, US International, etc.) the composition guard never fired for the editor's raw keydown events, so autopair ran mid-composition: chars were duplicated and the canceled composition never fired compositionend, leaving :editor/in-composition? stuck and suppressing every save until the block content vanished. - detect composition on raw DOM keyboard events in the keydown autopair guard - treat the first non-composing input as composition end when compositionend never fires - run autopair for ` and ~ (and the ^^ pair) on composition commit, restoring markdown shortcut parity with US layouts - add CDP-based dead-key emulation helpers and an e2e regression suite
hildersantos
force-pushed
the
fix/dead-key-composition
branch
from
July 21, 2026 13:11
81fb0e0 to
12ea5bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #logseq/db-test#10
Problem
On layouts where ` ~ ^ are dead keys (macOS BR, US International, etc.) the composition guard never fired for the editor's raw keydown events, so autopair ran mid-composition: chars were duplicated and the canceled composition never fired compositionend, leaving :editor/in-composition? stuck and suppressing every save until the block content vanished.
Solution