Fix sumBy to return NaN for non-numeric values (fixes #5818) #6072
+11
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue #5818 where
sumBywas returning a string concatenation instead ofNaNwhen encountering non-numeric values.Changes
baseSumfunction to check if values are numbers before additionNaNimmediately when a non-numeric value is encounteredTesting
NaNInfinity,-Infinity, andundefinedare handled correctlyExample
Before:
_.sumBy([{ a: 1 }, { a: 'f' }, { a: null }], 'a')→'1fnull'After:
_.sumBy([{ a: 1 }, { a: 'f' }, { a: null }], 'a')→NaNFixes #5818