fix: exclude NaN from isNumber #6011
Open
+20
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated isNumber so it now returns false for NaN values—including boxed numbers—by explicitly checking that the numeric value equals itself
Revised isNaN to perform its own number check instead of calling isNumber, preserving correct behavior for NaN primitives and objects
Added unit tests covering the new NaN behavior and adjusted existing expectations to reflect the change
Tidied prototype-pollution tests by replacing bracket notation with dot notation to satisfy style guidelines