Skip to content

fix: exclude NaN from isNumber (fixes #5981) #6007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: exclude NaN from isNumber (fixes #5981) #6007

wants to merge 1 commit into from
+85 −83

Conversation

@ThivyaElangovan121121
Copy link

@ThivyaElangovan121121 ThivyaElangovan121121 commented Jul 18, 2025

  • Handles both primitive and boxed NaNs.
  • Avoids calling Lodash methods inside Lodash internals — no recursion!
  • Safe across realms (e.g., iframes, VMs).
  • Avoids legacy quirks like ActiveX and non-standard behaviors.

@eglove
Copy link

eglove commented Aug 1, 2025 •
edited
Loading

I've been in support of this for a very long time. Last time it came up they said this was on purpose because NaN is a number in spec? But it defeats the purpose of a utility library to begin with. If we weren't accounting for edge cases like this, we'd just write flippant off the cuff custom utils.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Cassieminkus1 Cassieminkus1 Cassieminkus1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ThivyaElangovan121121 @eglove @Cassieminkus1 @GitUser121121