Fix LEAN type synthesis error in Nat domain formulas with pattern offsets #635
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LEAN formula generator produced type-inconsistent code for recursive formulas in Nat domain, causing "failed to synthesize HSub Nat Nat Int" errors. Parameters were wrapped with
Int.ofNatbut pattern offset constants remained as Nat literals, creating mixed-type expressions like(Int.ofNat n)+3.Changes
Int.ofNatwhen domain is "Nat" to ensure type consistencyExample
Before (type error):
After (type-consistent):
Note
Expression simplification doesn't merge
Int.ofNat-wrapped constants, so some formulas show(Int.ofNat n)+(Int.ofNat 10)+7instead of(Int.ofNat n)+(Int.ofNat 17). Both are mathematically equivalent and type-safe.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.