Fix empty formula generation for self-recursive functions #631
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formula generation was producing empty output for programs containing ROL operations in loops (e.g., A069195). The issue affected any program that generates a self-recursive formula like
a(n) = a(n-k).Root Cause
FormulaSimplify::replaceSimpleRecursiveRefsis designed to eliminate helper functions that are simple shifted references to other recursive functions (e.g.,a(n) = b(n+1)wherebis recursive). The helper functionisSimpleRecursiveReferencewas incorrectly treating self-recursive definitions as simple references:This caused the formula to be erased, resulting in empty output.
Changes
isSimpleRecursiveReferencewhenrefFuncName == funcNameThe fix is a 3-line guard placed immediately after extracting the referenced function name.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.