Add cell value scaling functions#449
Merged
vpipkt merged 8 commits intolocationtech:developfrom Jan 30, 2020
Merged
Conversation
Signed-off-by: Jason T. Brown <jason@astraea.earth>
Signed-off-by: Jason T. Brown <jason@astraea.earth>
Signed-off-by: Jason T. Brown <jason@astraea.earth>
Signed-off-by: Jason T. Brown <jason@astraea.earth>
Signed-off-by: Jason T. Brown <jason@astraea.earth>
Member
Author
…page Signed-off-by: Jason T. Brown <jason@astraea.earth>
metasim
suggested changes
Jan 27, 2020
Member
metasim
left a comment
metasim
left a comment
There was a problem hiding this comment.
Wow!
Wow!
Wow!
💯
Change Clip to Clamp and let's get it out in the wild!
| * min - scalar or tile setting the minimum value for each cell | ||
| * max - scalar or tile setting the maximum value for each cell""" | ||
| ) | ||
| case class Clip(left: Expression, middle: Expression, right: Expression) |
Member
There was a problem hiding this comment.
There's already precident for calling this kind of operation "clamp".
https://github.com/locationtech/rasterframes/search?q=clamp&unscoped_q=clamp
A clip in imagery usually implies trimming the pixel edges, where as a clamp is on the pixel values.
https://imagemagick.org/script/command-line-options.php#clamp
So my preference here (sorry) is to keep with that nomenclature.
core/src/main/scala/org/locationtech/rasterframes/expressions/localops/Max.scala
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| describe("standardize and rescale") { |
Member
There was a problem hiding this comment.
I wonder if these should go in the StatFunctionsSpec file....
Signed-off-by: Jason T. Brown <jason@astraea.earth>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #218
Functions we would like to include here:
Initial commit is just some of the functions. Still a few more to go.