Aggregate overview raster#430
Merged
vpipkt merged 19 commits intolocationtech:developfrom Jan 9, 2020
Merged
Conversation
…pe for easier navigation and maintenance.
Separated out aggregate function tests.
* develop: Fix rf_local_extract_bits argument parsing remove unused imports Python unit tests check read pipeline stages Cruft removal. Fix for ML transformer read/write Add failing unit tests for issue 425 ML custom transformer loading is broken Fixed `ReprojectToLayer` to work with `proj_raster`. Closes locationtech#357 Depends on locationtech#420.
* develop: PR feedback on NoData check for masking remove comments and cruft from unit test Fix for 409: assert on mask target must have NoData defined # Conflicts: # core/src/test/scala/org/locationtech/rasterframes/RasterFunctionsSpec.scala # docs/src/main/paradox/release-notes.md
Member
Author
|
At the risk of waiting too long to get feedback I'm opening this PR to review, in hopes of getting the core functionality merged and then incrementally updated after that. |
vpipkt
suggested changes
Dec 10, 2019
Member
vpipkt
left a comment
vpipkt
left a comment
There was a problem hiding this comment.
Just a few minor things.
I think we should add rf_render_color_ramp_png and / or rf_render_png to docs page about exporting / visualizing as well. To demonstrate a practical use of these functions.
...ain/scala/org/locationtech/rasterframes/expressions/transformers/CreateProjectedRaster.scala
Show resolved
Hide resolved
Signed-off-by: Jason T. Brown <jason@astraea.earth>
This was referenced Jan 6, 2020
…g page; clean up unsupervised learning output. Signed-off-by: Jason T. Brown <jason@astraea.earth>
Member
|
@metasim i think this one is ready for another look. |
This was referenced Jan 6, 2020
metasim
commented
Jan 8, 2020
Member
Author
metasim
left a comment
metasim
left a comment
There was a problem hiding this comment.
A few minor changes suggested. Thanks for taking this over the finish line, and figuring out the ipython magic!
core/src/main/scala/org/locationtech/rasterframes/util/DataFrameRenderers.scala
Show resolved
Hide resolved
Member
Author
|
@vpipkt A few more comments, but go ahead and merge when you're satisfied. |
This was referenced Jan 9, 2020
Signed-off-by: Jason T. Brown <jason@astraea.earth>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.