Merged
Conversation
vpipkt
approved these changes
Aug 9, 2019
Member
vpipkt
left a comment
vpipkt
left a comment
There was a problem hiding this comment.
I did a quite thorough round trip with an entire modis granule that has given us trouble recently. I read both the original and the df.write.geotiff version with rasterio. Results:
>>> np.all(original_array == my_array)
True
>>> for i in range(6):
>>> if original_meta['transform'][i] != 0:
>>> print(i, 'pct dif',
>>> (original_meta['transform'][i] - my_meta['transform'][i] ) / original_meta['transform'][i])
>>> else:
>>> print(i, 'equal zero', original_meta['transform'][i] == my_meta['transform'][i])
0 pct dif -4.5051436451237065e-13
1 equal zero True
2 pct dif 0.0
3 equal zero True
4 pct dif 4.48551338958537e-13
5 pct dif -0.0
>>> And the CRS checks out. Height and width agree. Datatypes agree.
I am calling this one good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixes #224