Merged
Conversation
add LocalStack v3.7.1, v4.3.0 support
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the project to include support for .NET 9 alongside .NET 8, while deprecating earlier framework support where applicable and updating build warnings.
- Updated supported platform listings in README files for LocalStack.Client, LocalStack.Client.Extensions, and the root project.
- Added pragma warning disable directives (CA1515) in several build-related files.
- Updated CI workflows to install and test using .NET 8 and .NET 9.
Reviewed Changes
Copilot reviewed 35 out of 43 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/LocalStack.Client.Extensions.Tests/Extensions/ObjectExtensions.cs | Added pragma warning disable for CA1515 to adjust accessibility. |
| src/LocalStack.Client/README.md | Updated supported platforms to include .NET 8 and .NET 9. |
| src/LocalStack.Client.Extensions/README.md | Updated supported platforms to include .NET 8 and .NET 9. |
| build/LocalStack.Build/Program.cs, Models/ProjMetadata.cs, BuildContext.cs | Added pragma warning disable for CA1515. |
| README.md | Updated supported platforms to include .NET 8 and .NET 9. |
| CHANGELOG.md | Documented the changes for v1.6.0 including .NET 9 support and .NET 6 deprecation. |
| .github/workflows/publish-nuget.yml, build-windows.yml, build-ubuntu.yml, build-macos.yml | Updated CI workflows to use .NET 8 and .NET 9 for installation and builds. |
Files not reviewed (8)
- Directory.Build.props: Language not supported
- Directory.Packages.props: Language not supported
- LICENSE: Language not supported
- build/LocalStack.Build/LocalStack.Build.csproj: Language not supported
- global.json: Language not supported
- src/LocalStack.Client.Extensions/LocalStack.Client.Extensions.csproj: Language not supported
- src/LocalStack.Client/LocalStack.Client.csproj: Language not supported
- tests/LocalStack.Client.Extensions.Tests/LocalStack.Client.Extensions.Tests.csproj: Language not supported
Comments suppressed due to low confidence (2)
.github/workflows/publish-nuget.yml:40
- Ensure that replacing .NET 6 with .NET 8 in the publish workflow is intentional and that all dependencies and configurations are aligned with this change.
- name: Install .NET 8
.github/workflows/build-macos.yml:41
- Double-check that updating the .NET installation from .NET 7 to .NET 9 in this workflow is expected and that any platform-specific concerns are addressed.
- name: Install .NET 9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Framework Support Updates:
Functional Tests Enhancements:
Package Updates:
Testing Compatibility: