make the ephemeral startup configurable for users#37
make the ephemeral startup configurable for users#37HarshCasper wants to merge 2 commits intomainfrom
Conversation
|
The ephemeral instance for the application preview has been shut down |
HarshCasper
force-pushed
the
config-option
branch
8 times, most recently
from
5f60e10 to
d20755a
Compare
HarshCasper
force-pushed
the
config-option
branch
from
d20755a to
ef89543
Compare
lukqw
left a comment
lukqw
left a comment
There was a problem hiding this comment.
Awesome that we're building this!
Added a first set of comments.
| required: false | ||
| default: '30' | ||
|
|
||
| ephemeral-configuration: |
There was a problem hiding this comment.
would it make more sense to keep this as configuration, similar to what we have in place over in the normal startup action? link: https://github.com/localstack/setup-localstack/blob/main/startup/action.yml
If not, then you'd also have to reflect this argument in the README.
There was a problem hiding this comment.
Furthermore this would have to be added in the main action: https://github.com/localstack/setup-localstack/blob/main/action.yml#L138
| configuration="${{ inputs.ephemeral-configuration }}" | ||
| echo "Creating preview environment with configuration: $configuration" | ||
| # Convert configuration to JSON format | ||
| IFS=',' read -r -a configArray <<< "$configuration" | ||
| envVarsJson=$(jq -n '{}') | ||
| for config in "${configArray[@]}"; do | ||
| IFS='=' read -r -a kv <<< "$config" | ||
| key=${kv[0]// /} | ||
| value=${kv[1]// /} | ||
| envVarsJson=$(echo $envVarsJson | jq --arg key "$key" --arg value "$value" '. + {($key): $value}') | ||
| done | ||
| echo "Configuration JSON: $envVarsJson" | ||
|
|
||
| envVarsJson=$(echo $envVarsJson | jq --arg autoLoadPod "$autoLoadPod" --arg extensionAutoInstall "$extensionAutoInstall" '. + {AUTO_LOAD_POD: $autoLoadPod, EXTENSION_AUTO_INSTALL: $extensionAutoInstall}') |
There was a problem hiding this comment.
this is oddly convoluted, is there a way we could improve readability and maintenance?
|
@HarshCasper any chance we could get this one merged? |
|
Hi @HarshCasper, |
3 participants
No description provided.